Re: [PATCH 1/4] configure: Use discovered make for in-source build

2020-08-25 Thread Eric Blake
On 8/25/20 5:16 AM, Roman Bolshakov wrote: Hi Eric, What if we just print an error if build/config-host.mak can't be found? ifeq ($(wildcard build/config-host.mak),) $(error "Incomplete configuration. Please run ./configure") endif IMO this is more sane approach than proceeding with partiall

Re: [PATCH 1/4] configure: Use discovered make for in-source build

2020-08-25 Thread Roman Bolshakov
On Tue, Aug 25, 2020 at 01:07:55AM +0300, Roman Bolshakov wrote: > On Mon, Aug 24, 2020 at 09:37:07AM -0500, Eric Blake wrote: > > On 8/22/20 4:21 PM, Roman Bolshakov wrote: > > > @@ -38,6 +38,8 @@ then > > > # This file is auto-generated by configure to support in-source tree > > > # 'make' co

Re: [PATCH 1/4] configure: Use discovered make for in-source build

2020-08-24 Thread Roman Bolshakov
On Mon, Aug 24, 2020 at 09:37:07AM -0500, Eric Blake wrote: > On 8/22/20 4:21 PM, Roman Bolshakov wrote: > > @@ -38,6 +38,8 @@ then > > # This file is auto-generated by configure to support in-source tree > > # 'make' command invocation > > +include build/config-host.mak > > Should this use '-

Re: [PATCH 1/4] configure: Use discovered make for in-source build

2020-08-24 Thread Eric Blake
On 8/22/20 4:21 PM, Roman Bolshakov wrote: A recursive make is inovked if in-source build is used but $(MAKE) is the same as the one used in the original make invocaton. Some platforms have preference to use gmake, or a make passed as an option to "configure". Honor the choice. Signed-off-by: R

Re: [PATCH 1/4] configure: Use discovered make for in-source build

2020-08-24 Thread Eric Blake
On 8/22/20 4:21 PM, Roman Bolshakov wrote: A recursive make is inovked if in-source build is used but $(MAKE) is invoked the same as the one used in the original make invocaton. invocation Some platforms have preference to use gmake, or a make passed as an option to "configure". Honor th

Re: [PATCH 1/4] configure: Use discovered make for in-source build

2020-08-24 Thread Daniel P . Berrangé
On Sun, Aug 23, 2020 at 12:21:26AM +0300, Roman Bolshakov wrote: > A recursive make is inovked if in-source build is used but $(MAKE) is > the same as the one used in the original make invocaton. > > Some platforms have preference to use gmake, or a make passed as an > option to "configure". Honor

[PATCH 1/4] configure: Use discovered make for in-source build

2020-08-22 Thread Roman Bolshakov
A recursive make is inovked if in-source build is used but $(MAKE) is the same as the one used in the original make invocaton. Some platforms have preference to use gmake, or a make passed as an option to "configure". Honor the choice. Signed-off-by: Roman Bolshakov --- configure | 2 ++ 1 file