Re: [PATCH 1/4] chardev: fix qemu_chr_open_fd() being called with fd=-1

2021-08-04 Thread Marc-André Lureau
Hi On Tue, Aug 3, 2021 at 12:41 PM Daniel P. Berrangé wrote: > On Fri, Jul 23, 2021 at 02:28:22PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > The "file" chardev may call qemu_chr_open_fd() with fd_in=-1. This may > > cause invalid system calls, as the QIOChan

Re: [PATCH 1/4] chardev: fix qemu_chr_open_fd() being called with fd=-1

2021-08-03 Thread Daniel P . Berrangé
On Fri, Jul 23, 2021 at 02:28:22PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The "file" chardev may call qemu_chr_open_fd() with fd_in=-1. This may > cause invalid system calls, as the QIOChannel is assumed to be properly > initialized later on. > > Signed-off-by: M

[PATCH 1/4] chardev: fix qemu_chr_open_fd() being called with fd=-1

2021-07-23 Thread marcandre . lureau
From: Marc-André Lureau The "file" chardev may call qemu_chr_open_fd() with fd_in=-1. This may cause invalid system calls, as the QIOChannel is assumed to be properly initialized later on. Signed-off-by: Marc-André Lureau --- chardev/char-fd.c | 22 +- 1 file changed, 13 in