Re: [PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-09 Thread Cindy Lu
On Tue, 6 Aug 2024 at 21:30, Michael S. Tsirkin wrote: > > On Tue, Aug 06, 2024 at 08:58:01AM +0800, Cindy Lu wrote: > > When using a VDPA device, it is important to ensure that > > the MAC address in the hardware matches the MAC address > > from the QEMU command line. > > This will allow the devi

Re: [PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-09 Thread Cindy Lu
On Wed, 7 Aug 2024 at 10:36, Jason Wang wrote: > On Tue, Aug 6, 2024 at 5:44 PM Cindy Lu wrote: > > > > On Tue, 6 Aug 2024 at 11:07, Jason Wang wrote: > > > > > > On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote: > > > > > > > > When using a VDPA device, it is important to ensure that > > > > the

Re: [PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-09 Thread Cindy Lu
On Tue, 6 Aug 2024 at 19:13, Yan Vugenfirer wrote: > Do we check that the MAC from the command line or HW was formed > correctly and doesn't include multicast bit? > > Best regards, > Yan. > > I didn't include a check for this, but it seems the vhost also doesn't have this kind of verification. I

Re: [PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-06 Thread Jason Wang
On Tue, Aug 6, 2024 at 5:44 PM Cindy Lu wrote: > > On Tue, 6 Aug 2024 at 11:07, Jason Wang wrote: > > > > On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote: > > > > > > When using a VDPA device, it is important to ensure that > > > the MAC address in the hardware matches the MAC address > > > from t

Re: [PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2024 at 08:58:01AM +0800, Cindy Lu wrote: > When using a VDPA device, it is important to ensure that > the MAC address in the hardware matches the MAC address > from the QEMU command line. > This will allow the device to boot. > > Signed-off-by: Cindy Lu Always post threads with

Re: [PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-06 Thread Yan Vugenfirer
Do we check that the MAC from the command line or HW was formed correctly and doesn't include multicast bit? Best regards, Yan. On Tue, Aug 6, 2024 at 12:45 PM Cindy Lu wrote: > > On Tue, 6 Aug 2024 at 11:07, Jason Wang wrote: > > > > On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote: > > > > > >

Re: [PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-06 Thread Cindy Lu
On Tue, 6 Aug 2024 at 11:07, Jason Wang wrote: > > On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote: > > > > When using a VDPA device, it is important to ensure that > > the MAC address in the hardware matches the MAC address > > from the QEMU command line. > > This will allow the device to boot. >

Re: [PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-05 Thread Jason Wang
On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote: > > When using a VDPA device, it is important to ensure that > the MAC address in the hardware matches the MAC address > from the QEMU command line. > This will allow the device to boot. > > Signed-off-by: Cindy Lu > --- > hw/net/virtio-net.c | 33 +

[PATCH 1/3] virtio_net: Add the check for vdpa's mac address

2024-08-05 Thread Cindy Lu
When using a VDPA device, it is important to ensure that the MAC address in the hardware matches the MAC address from the QEMU command line. This will allow the device to boot. Signed-off-by: Cindy Lu --- hw/net/virtio-net.c | 33 + 1 file changed, 29 insertions(+