Re: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions

2023-06-07 Thread Philippe Mathieu-Daudé
On 6/6/23 16:45, Fabiano Rosas wrote: The code in threadinfo.c is only used for the QMP command query-migrationthreads. Make it explicit that this is something related to QMP. The current names are also too generic for a piece of code that doesn't affect the migration directly in any way. Signe

Re: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions

2023-06-06 Thread Juan Quintela
Fabiano Rosas wrote: > The code in threadinfo.c is only used for the QMP command > query-migrationthreads. Make it explicit that this is something > related to QMP. > > The current names are also too generic for a piece of code that > doesn't affect the migration directly in any way. > > Signed-of

Re: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions

2023-06-06 Thread Peter Xu
On Tue, Jun 06, 2023 at 04:34:31PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Tue, Jun 06, 2023 at 11:45:49AM -0300, Fabiano Rosas wrote: > >> The code in threadinfo.c is only used for the QMP command > >> query-migrationthreads. Make it explicit that this is something > >> related t

Re: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions

2023-06-06 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Jun 06, 2023 at 11:45:49AM -0300, Fabiano Rosas wrote: >> The code in threadinfo.c is only used for the QMP command >> query-migrationthreads. Make it explicit that this is something >> related to QMP. >> >> The current names are also too generic for a piece of code th

Re: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions

2023-06-06 Thread Peter Xu
On Tue, Jun 06, 2023 at 11:45:49AM -0300, Fabiano Rosas wrote: > The code in threadinfo.c is only used for the QMP command > query-migrationthreads. Make it explicit that this is something > related to QMP. > > The current names are also too generic for a piece of code that > doesn't affect the mi

[PATCH 1/3] migration/multifd: Rename threadinfo.c functions

2023-06-06 Thread Fabiano Rosas
The code in threadinfo.c is only used for the QMP command query-migrationthreads. Make it explicit that this is something related to QMP. The current names are also too generic for a piece of code that doesn't affect the migration directly in any way. Signed-off-by: Fabiano Rosas --- migration/