Re: [PATCH 1/3] m25p80: Convert to support tracing

2020-02-05 Thread Guenter Roeck
On Wed, Feb 05, 2020 at 06:10:44PM +0100, Cédric Le Goater wrote: > On 2/5/20 5:35 PM, Guenter Roeck wrote: > > On Wed, Feb 05, 2020 at 11:05:04AM +0100, Cédric Le Goater wrote: > >> On 2/3/20 7:09 PM, Guenter Roeck wrote: > >>> While at it, add some trace messages to help debug problems > >>> seen

Re: [PATCH 1/3] m25p80: Convert to support tracing

2020-02-05 Thread Cédric Le Goater
On 2/5/20 5:35 PM, Guenter Roeck wrote: > On Wed, Feb 05, 2020 at 11:05:04AM +0100, Cédric Le Goater wrote: >> On 2/3/20 7:09 PM, Guenter Roeck wrote: >>> While at it, add some trace messages to help debug problems >>> seen when running the latest Linux kernel. >> >> In case you resend, It would be

Re: [PATCH 1/3] m25p80: Convert to support tracing

2020-02-05 Thread Guenter Roeck
On Wed, Feb 05, 2020 at 11:05:04AM +0100, Cédric Le Goater wrote: > On 2/3/20 7:09 PM, Guenter Roeck wrote: > > While at it, add some trace messages to help debug problems > > seen when running the latest Linux kernel. > > In case you resend, It would be nice to printout a flash id in the tracing

Re: [PATCH 1/3] m25p80: Convert to support tracing

2020-02-05 Thread Cédric Le Goater
On 2/3/20 7:09 PM, Guenter Roeck wrote: > While at it, add some trace messages to help debug problems > seen when running the latest Linux kernel. In case you resend, It would be nice to printout a flash id in the tracing else I have a patch for it on top of yours. It helped me track a squashfs co

Re: [PATCH 1/3] m25p80: Convert to support tracing

2020-02-04 Thread Guenter Roeck
On 2/3/20 11:16 PM, Cédric Le Goater wrote: On 2/3/20 7:09 PM, Guenter Roeck wrote: While at it, add some trace messages to help debug problems seen when running the latest Linux kernel. Signed-off-by: Guenter Roeck Reviewed-by: Cédric Le Goater We have been chasing a bug for years on the

Re: [PATCH 1/3] m25p80: Convert to support tracing

2020-02-04 Thread Philippe Mathieu-Daudé
On 2/3/20 7:09 PM, Guenter Roeck wrote: While at it, add some trace messages to help debug problems seen when running the latest Linux kernel. Signed-off-by: Guenter Roeck --- hw/block/m25p80.c | 48 --- hw/block/trace-events | 16 +++

Re: [PATCH 1/3] m25p80: Convert to support tracing

2020-02-03 Thread Cédric Le Goater
On 2/3/20 7:09 PM, Guenter Roeck wrote: > While at it, add some trace messages to help debug problems > seen when running the latest Linux kernel. > > Signed-off-by: Guenter Roeck Reviewed-by: Cédric Le Goater We have been chasing a bug for years on the witherspoon-bmc machine using UBIfs. I

Re: [PATCH 1/3] m25p80: Convert to support tracing

2020-02-03 Thread Alistair Francis
On Mon, Feb 3, 2020 at 10:10 AM Guenter Roeck wrote: > > While at it, add some trace messages to help debug problems > seen when running the latest Linux kernel. > > Signed-off-by: Guenter Roeck Reviewed-by: Alistair Francis Alistair > --- > hw/block/m25p80.c | 48 ---

[PATCH 1/3] m25p80: Convert to support tracing

2020-02-03 Thread Guenter Roeck
While at it, add some trace messages to help debug problems seen when running the latest Linux kernel. Signed-off-by: Guenter Roeck --- hw/block/m25p80.c | 48 --- hw/block/trace-events | 16 +++ 2 files changed, 38 insertions(+), 26 deleti