Re: [PATCH 1/3] hw/qdev: Restrict qdev_get_gpio_out_connector() to qdev-internal.h

2022-01-03 Thread wangyanan (Y)
On 2021/12/31 20:11, Philippe Mathieu-Daudé wrote: On 12/31/21 08:30, wangyanan (Y) wrote: Hi, On 2021/12/30 6:52, Philippe Mathieu-Daudé wrote: qdev_get_gpio_out_connector() is called by sysbus_get_connected_irq() which is only used by platform-bus.c; restrict it to hw/core/ by adding a loc

Re: [PATCH 1/3] hw/qdev: Restrict qdev_get_gpio_out_connector() to qdev-internal.h

2021-12-31 Thread Philippe Mathieu-Daudé
On 12/31/21 08:30, wangyanan (Y) wrote: > Hi, > > On 2021/12/30 6:52, Philippe Mathieu-Daudé wrote: >> qdev_get_gpio_out_connector() is called by sysbus_get_connected_irq() >> which is only used by platform-bus.c; restrict it to hw/core/ by >> adding a local "qdev-internal.h" header. >> >> Signed-

Re: [PATCH 1/3] hw/qdev: Restrict qdev_get_gpio_out_connector() to qdev-internal.h

2021-12-30 Thread wangyanan (Y)
Hi, On 2021/12/30 6:52, Philippe Mathieu-Daudé wrote: qdev_get_gpio_out_connector() is called by sysbus_get_connected_irq() which is only used by platform-bus.c; restrict it to hw/core/ by adding a local "qdev-internal.h" header. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-interna

[PATCH 1/3] hw/qdev: Restrict qdev_get_gpio_out_connector() to qdev-internal.h

2021-12-29 Thread Philippe Mathieu-Daudé
qdev_get_gpio_out_connector() is called by sysbus_get_connected_irq() which is only used by platform-bus.c; restrict it to hw/core/ by adding a local "qdev-internal.h" header. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-internal.h | 15 +++ include/hw/qdev-core.h | 18 ---