Re: [PATCH 1/3] block: Activate recursively even for already active nodes

2019-12-19 Thread Max Reitz
On 17.12.19 15:59, Kevin Wolf wrote: > bdrv_invalidate_cache_all() assumes that all nodes in a given subtree > are either active or inactive when it starts. Therefore, as soon as it > arrives at an already active node, it stops. > > However, this assumption is wrong. For example, it's possible to

Re: [PATCH 1/3] block: Activate recursively even for already active nodes

2019-12-18 Thread Kevin Wolf
Am 17.12.2019 um 15:59 hat Kevin Wolf geschrieben: > bdrv_invalidate_cache_all() assumes that all nodes in a given subtree > are either active or inactive when it starts. Therefore, as soon as it > arrives at an already active node, it stops. > > However, this assumption is wrong. For example, it'

[PATCH 1/3] block: Activate recursively even for already active nodes

2019-12-17 Thread Kevin Wolf
bdrv_invalidate_cache_all() assumes that all nodes in a given subtree are either active or inactive when it starts. Therefore, as soon as it arrives at an already active node, it stops. However, this assumption is wrong. For example, it's possible to take a snapshot of an inactive node, which resu