Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-18 Thread Michael S. Tsirkin
On Wed, Apr 05, 2023 at 07:21:07PM +0200, David 'Digit' Turner wrote: > The source file uses VIRTIO_F_VERSION_1 which is > not defined by on Debian 10. > > The system-provided which > does not include the macro definition is included > through , so fix the issue by including > the standard-heade

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-18 Thread David Turner
On Tue, Apr 18, 2023 at 10:47 AM Daniel P. Berrangé wrote: > On Fri, Apr 07, 2023 at 11:25:14AM +0200, David Turner wrote: > > I meant glibc-2.17, I am using a sysroot to ensure the generated binaries > > run on older Linux distributions. > > I think that would be considered an unsupported buld c

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-18 Thread Daniel P . Berrangé
On Fri, Apr 07, 2023 at 11:25:14AM +0200, David Turner wrote: > I meant glibc-2.17, I am using a sysroot to ensure the generated binaries > run on older Linux distributions. I think that would be considered an unsupported buld configuration from QEMU's POV. Our platform policy is declared here:

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-07 Thread Michael S. Tsirkin
On Fri, Apr 07, 2023 at 11:47:50AM +0200, David Turner wrote: > Digging a little further, the top-level meson.build for qemu has the > following: > > > if targetos == 'linux' >   add_project_arguments('-isystem', meson.current_source_dir() / > 'linux-headers', >                  

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-07 Thread David Turner
On Fri, Apr 7, 2023 at 11:46 AM Michael S. Tsirkin wrote: > On Fri, Apr 07, 2023 at 11:29:46AM +0200, David Turner wrote: > > So it looks like that for some reason, the QEMU linux-headers directory > is not > > in the include search path for this compilation command, and that the > > system-or-sy

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-07 Thread David Turner
Digging a little further, the top-level meson.build for qemu has the following: if targetos == 'linux' add_project_arguments('-isystem', meson.current_source_dir() / 'linux-headers', '-isystem', 'linux-headers', language: all_languages) endif But

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-07 Thread Michael S. Tsirkin
On Fri, Apr 07, 2023 at 11:29:46AM +0200, David Turner wrote: > So it looks like that for some reason, the QEMU linux-headers directory is not > in the include search path for this compilation command, and that the > system-or-sysroot provided is picked instead. Fixing this > might > be a better

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-07 Thread David Turner
So it looks like that for some reason, the QEMU linux-headers directory is not in the include search path for this compilation command, and that the system-or-sysroot provided is picked instead. Fixing this might be a better long-term fix than what I am proposing in this patch. I am not sure how t

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-07 Thread David Turner
I meant glibc-2.17, I am using a sysroot to ensure the generated binaries run on older Linux distributions. On Fri, Apr 7, 2023 at 11:24 AM David Turner wrote: > The of glib-2.17 begins with: > > #ifndef _LINUX_VHOST_H > #define _LINUX_VHOST_H > /* Userspace interface for in-kernel virtio accel

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-07 Thread David Turner
The of glib-2.17 begins with: #ifndef _LINUX_VHOST_H #define _LINUX_VHOST_H /* Userspace interface for in-kernel virtio accelerators. */ /* vhost is used to reduce the number of system calls involved in virtio. * * Existing virtio net code is used in the guest without modification. * * This h

Re: [PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-07 Thread Michael S. Tsirkin
If you are reposting, please version patchsets, E.g. -v2 flag for git format-patch will enerate [PATCH v2] for you. Repeating what I said on previous version: On Wed, Apr 05, 2023 at 07:21:07PM +0200, David 'Digit' Turner wrote: > The source file uses VIRTIO_F_VERSION_1 which is > not defined by

[PATCH 1/3] Fix libvhost-user.c compilation.

2023-04-05 Thread David 'Digit' Turner
The source file uses VIRTIO_F_VERSION_1 which is not defined by on Debian 10. The system-provided which does not include the macro definition is included through , so fix the issue by including the standard-headers version before that. Signed-off-by: David 'Digit' Turner --- subprojects/libvh