Re: [PATCH 1/2] util/osdep: Avoid madvise proto on modern Solaris

2022-03-14 Thread Andrew Deason
On Mon, 14 Mar 2022 19:01:06 + Daniel P. Berrangé wrote: > We have a general purpose platform support policy > > https://www.qemu.org/docs/master/about/build-platforms.html > > where the common rule ends up being "the current major release, > and the previous major release for 2 years ove

Re: [PATCH 1/2] util/osdep: Avoid madvise proto on modern Solaris

2022-03-14 Thread Daniel P . Berrangé
On Mon, Mar 14, 2022 at 01:18:00PM -0500, Andrew Deason wrote: > On Mon, 14 Mar 2022 16:36:00 + > Peter Maydell wrote: > > > On Mon, 14 Mar 2022 at 16:12, Andrew Deason wrote: > > > #ifdef CONFIG_SOLARIS > > > #include > > > +#ifndef HAVE_MADVISE_PROTO > > > /* See MySQL bug #7156 (http:

Re: [PATCH 1/2] util/osdep: Avoid madvise proto on modern Solaris

2022-03-14 Thread Peter Maydell
On Mon, 14 Mar 2022 at 18:18, Andrew Deason wrote: > > On Mon, 14 Mar 2022 16:36:00 + > Peter Maydell wrote: > > > On Mon, 14 Mar 2022 at 16:12, Andrew Deason wrote: > > > #ifdef CONFIG_SOLARIS > > > #include > > > +#ifndef HAVE_MADVISE_PROTO > > > /* See MySQL bug #7156 (http://bugs.mys

Re: [PATCH 1/2] util/osdep: Avoid madvise proto on modern Solaris

2022-03-14 Thread Andrew Deason
On Mon, 14 Mar 2022 16:36:00 + Peter Maydell wrote: > On Mon, 14 Mar 2022 at 16:12, Andrew Deason wrote: > > #ifdef CONFIG_SOLARIS > > #include > > +#ifndef HAVE_MADVISE_PROTO > > /* See MySQL bug #7156 (http://bugs.mysql.com/bug.php?id=7156) for > > discussion about Solaris header p

Re: [PATCH 1/2] util/osdep: Avoid madvise proto on modern Solaris

2022-03-14 Thread Peter Maydell
On Mon, 14 Mar 2022 at 16:12, Andrew Deason wrote: > > On older Solaris releases, we didn't get a protype for madvise, and so > util/osdep.c provides its own prototype. Some time between the public > Solaris 11.4 release and Solaris 11.4.42 CBE, we started getting an > madvise prototype that looks

[PATCH 1/2] util/osdep: Avoid madvise proto on modern Solaris

2022-03-14 Thread Andrew Deason
On older Solaris releases, we didn't get a protype for madvise, and so util/osdep.c provides its own prototype. Some time between the public Solaris 11.4 release and Solaris 11.4.42 CBE, we started getting an madvise prototype that looks like this: extern int madvise(void *, size_t, int); Whi