Re: [PATCH 1/2] util/cutils: Turn FIXME comment into QEMU_BUILD_BUG_ON()

2019-11-25 Thread Philippe Mathieu-Daudé
On 11/25/19 2:38 PM, Markus Armbruster wrote: qemu_strtoi64() assumes int64_t is long long. This is marked FIXME. Replace by a QEMU_BUILD_BUG_ON() to avoid surprises. Same for qemu_strtou64(). Fix a typo in qemu_strtoul()'s contract while there. Signed-off-by: Markus Armbruster --- util/cu

[PATCH 1/2] util/cutils: Turn FIXME comment into QEMU_BUILD_BUG_ON()

2019-11-25 Thread Markus Armbruster
qemu_strtoi64() assumes int64_t is long long. This is marked FIXME. Replace by a QEMU_BUILD_BUG_ON() to avoid surprises. Same for qemu_strtou64(). Fix a typo in qemu_strtoul()'s contract while there. Signed-off-by: Markus Armbruster --- util/cutils.c | 8 +--- 1 file changed, 5 insertions