Re: [PATCH 1/2] tcg: Clear plugin_mem_cbs on TB exit

2023-03-02 Thread Richard Henderson
On 3/1/23 02:05, Emilio Cota wrote: As I mentioned in the patch that is being superseded here I like this approach -- it is simpler and generates less code. I'd also like to see the plugin_gen_disable_mem_helpers function go away, and a mention somewhere that now we are intentionally not clearin

Re: [PATCH 1/2] tcg: Clear plugin_mem_cbs on TB exit

2023-03-02 Thread Richard Henderson
On 3/1/23 02:05, Emilio Cota wrote: As I mentioned in the patch that is being superseded here I like this approach -- it is simpler and generates less code. I'd also like to see the plugin_gen_disable_mem_helpers function go away, and a mention somewhere that now we are intentionally not clearin

Re: [PATCH 1/2] tcg: Clear plugin_mem_cbs on TB exit

2023-03-01 Thread Emilio Cota
As I mentioned in the patch that is being superseded here I like this approach -- it is simpler and generates less code. I'd also like to see the plugin_gen_disable_mem_helpers function go away, and a mention somewhere that now we are intentionally not clearing cpu->plugin_mem_cbs until TB exit (b

[PATCH 1/2] tcg: Clear plugin_mem_cbs on TB exit

2023-02-28 Thread Richard Henderson
Do this in cpu_tb_exec (normal exit) and cpu_loop_exit (exception), adjacent to where we reset can_do_io. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1381 Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec-common.c | 4 accel/tcg/cpu-exec.c| 5 +++-- 2 files changed