Re: [PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-04-05 Thread Alistair Francis
On Thu, Apr 6, 2023 at 1:02 PM liweiwei wrote: > > > On 2023/4/6 10:24, Alistair Francis wrote: > > On Thu, Apr 6, 2023 at 12:14 PM liweiwei wrote: > >> > >> On 2023/4/6 09:46, Alistair Francis wrote: > >>> On Thu, Apr 6, 2023 at 10:56 AM liweiwei wrote: > On 2023/4/6 08:43, Alistair Franci

Re: [PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-04-05 Thread liweiwei
On 2023/4/6 10:24, Alistair Francis wrote: On Thu, Apr 6, 2023 at 12:14 PM liweiwei wrote: On 2023/4/6 09:46, Alistair Francis wrote: On Thu, Apr 6, 2023 at 10:56 AM liweiwei wrote: On 2023/4/6 08:43, Alistair Francis wrote: On Thu, Mar 30, 2023 at 11:59 PM Weiwei Li wrote: The MPP wil

Re: [PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-04-05 Thread liweiwei
On 2023/4/6 10:24, Alistair Francis wrote: On Thu, Apr 6, 2023 at 12:14 PM liweiwei wrote: On 2023/4/6 09:46, Alistair Francis wrote: On Thu, Apr 6, 2023 at 10:56 AM liweiwei wrote: On 2023/4/6 08:43, Alistair Francis wrote: On Thu, Mar 30, 2023 at 11:59 PM Weiwei Li wrote: The MPP wil

Re: [PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-04-05 Thread Alistair Francis
On Thu, Apr 6, 2023 at 12:14 PM liweiwei wrote: > > > On 2023/4/6 09:46, Alistair Francis wrote: > > On Thu, Apr 6, 2023 at 10:56 AM liweiwei wrote: > >> > >> On 2023/4/6 08:43, Alistair Francis wrote: > >> > >> On Thu, Mar 30, 2023 at 11:59 PM Weiwei Li wrote: > >> > >> The MPP will be set to t

Re: [PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-04-05 Thread liweiwei
On 2023/4/6 09:46, Alistair Francis wrote: On Thu, Apr 6, 2023 at 10:56 AM liweiwei wrote: On 2023/4/6 08:43, Alistair Francis wrote: On Thu, Mar 30, 2023 at 11:59 PM Weiwei Li wrote: The MPP will be set to the least-privileged supported mode (U if U-mode is implemented, else M). I don't

Re: [PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-04-05 Thread Alistair Francis
On Thu, Apr 6, 2023 at 10:56 AM liweiwei wrote: > > > On 2023/4/6 08:43, Alistair Francis wrote: > > On Thu, Mar 30, 2023 at 11:59 PM Weiwei Li wrote: > > The MPP will be set to the least-privileged supported mode (U if > U-mode is implemented, else M). > > I don't think this is right, the spec i

Re: [PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-04-05 Thread liweiwei
On 2023/4/6 08:43, Alistair Francis wrote: On Thu, Mar 30, 2023 at 11:59 PM Weiwei Li wrote: The MPP will be set to the least-privileged supported mode (U if U-mode is implemented, else M). I don't think this is right, the spec in section 8.6.4 says this: Sorry, I didn't find this section i

Re: [PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-04-05 Thread Alistair Francis
On Thu, Mar 30, 2023 at 11:59 PM Weiwei Li wrote: > > The MPP will be set to the least-privileged supported mode (U if > U-mode is implemented, else M). I don't think this is right, the spec in section 8.6.4 says this: "MRET then in mstatus/mstatush sets MPV=0, MPP=0, MIE=MPIE, and MPIE=1" So i

[PATCH 1/2] target/riscv: Fix the mstatus.MPP value after executing MRET

2023-03-30 Thread Weiwei Li
The MPP will be set to the least-privileged supported mode (U if U-mode is implemented, else M). Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/op_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/op_helper.c b/target/riscv/op_he