Re: [PATCH 1/2] target/ppc: Fix slbia TLB invalidation gap

2020-03-18 Thread David Gibson
On Wed, Mar 18, 2020 at 02:41:34PM +1000, Nicholas Piggin wrote: > slbia must invalidate TLBs even if it does not remove a valid SLB > entry, because slbmte can overwrite valid entries without removing > their TLBs. > > As the architecture says, slbia invalidates all lookaside information, > not c

Re: [PATCH 1/2] target/ppc: Fix slbia TLB invalidation gap

2020-03-18 Thread David Gibson
On Wed, Mar 18, 2020 at 05:52:32PM +0100, Greg Kurz wrote: 65;5803;1c> On Wed, 18 Mar 2020 14:41:34 +1000 > Nicholas Piggin wrote: > > > slbia must invalidate TLBs even if it does not remove a valid SLB > > entry, because slbmte can overwrite valid entries without removing > > their TLBs. > > >

Re: [EXTERNAL] [PATCH 1/2] target/ppc: Fix slbia TLB invalidation gap

2020-03-18 Thread Nicholas Piggin
Cédric Le Goater's on March 19, 2020 2:45 am: > On 3/18/20 5:41 AM, Nicholas Piggin wrote: >> slbia must invalidate TLBs even if it does not remove a valid SLB >> entry, because slbmte can overwrite valid entries without removing >> their TLBs. >> >> As the architecture says, slbia invalidates all

Re: [PATCH 1/2] target/ppc: Fix slbia TLB invalidation gap

2020-03-18 Thread Greg Kurz
On Wed, 18 Mar 2020 14:41:34 +1000 Nicholas Piggin wrote: > slbia must invalidate TLBs even if it does not remove a valid SLB > entry, because slbmte can overwrite valid entries without removing > their TLBs. > > As the architecture says, slbia invalidates all lookaside information, > not condit

Re: [EXTERNAL] [PATCH 1/2] target/ppc: Fix slbia TLB invalidation gap

2020-03-18 Thread Cédric Le Goater
On 3/18/20 5:41 AM, Nicholas Piggin wrote: > slbia must invalidate TLBs even if it does not remove a valid SLB > entry, because slbmte can overwrite valid entries without removing > their TLBs. > > As the architecture says, slbia invalidates all lookaside information, > not conditionally based on

[PATCH 1/2] target/ppc: Fix slbia TLB invalidation gap

2020-03-17 Thread Nicholas Piggin
slbia must invalidate TLBs even if it does not remove a valid SLB entry, because slbmte can overwrite valid entries without removing their TLBs. As the architecture says, slbia invalidates all lookaside information, not conditionally based on if it removed valid entries. It does not seem possible