Re: [PATCH 1/2] target/cris: Use MMUAccessType enum type when possible

2021-02-04 Thread Edgar E. Iglesias
On Wed, Feb 03, 2021 at 04:45:50PM -1000, Richard Henderson wrote: > On 1/27/21 2:32 PM, Philippe Mathieu-Daudé wrote: > > Replace the 0/1/2 magic values by the corresponding MMUAccessType. > > We can remove a comment as enum names are self explicit. > > > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH 1/2] target/cris: Use MMUAccessType enum type when possible

2021-02-03 Thread Richard Henderson
On 1/27/21 2:32 PM, Philippe Mathieu-Daudé wrote: > Replace the 0/1/2 magic values by the corresponding MMUAccessType. > We can remove a comment as enum names are self explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/cris/helper.c | 4 ++-- > target/cris/mmu.c| 13 ++--

[PATCH 1/2] target/cris: Use MMUAccessType enum type when possible

2021-01-27 Thread Philippe Mathieu-Daudé
Replace the 0/1/2 magic values by the corresponding MMUAccessType. We can remove a comment as enum names are self explicit. Signed-off-by: Philippe Mathieu-Daudé --- target/cris/helper.c | 4 ++-- target/cris/mmu.c| 13 ++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --