Re: [PATCH 1/2] migration/savevm: Remove extra load cleanup calls

2024-09-17 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Sep 17, 2024 at 03:58:01PM -0300, Fabiano Rosas wrote: >> There are two qemu_loadvm_state_cleanup() calls that were introduced >> when qemu_loadvm_state_setup() was still called before loading the >> configuration section, so there was state to be cleaned up if the >> h

Re: [PATCH 1/2] migration/savevm: Remove extra load cleanup calls

2024-09-17 Thread Peter Xu
On Tue, Sep 17, 2024 at 03:58:01PM -0300, Fabiano Rosas wrote: > There are two qemu_loadvm_state_cleanup() calls that were introduced > when qemu_loadvm_state_setup() was still called before loading the > configuration section, so there was state to be cleaned up if the > header checks failed. > >

[PATCH 1/2] migration/savevm: Remove extra load cleanup calls

2024-09-17 Thread Fabiano Rosas
There are two qemu_loadvm_state_cleanup() calls that were introduced when qemu_loadvm_state_setup() was still called before loading the configuration section, so there was state to be cleaned up if the header checks failed. However, commit 9e14b84908 ("migration/savevm: load_header before load_set

Re: [PATCH 1/2] migration/savevm: Remove extra load cleanup calls

2024-09-17 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Sep 13, 2024 at 07:05:41PM -0300, Fabiano Rosas wrote: >> There are two qemu_loadvm_state_cleanup() calls that were introduced >> when qemu_loadvm_state_setup() was still called before loading the >> configuration section, so there was state to be cleaned up if the >> h

Re: [PATCH 1/2] migration/savevm: Remove extra load cleanup calls

2024-09-17 Thread Peter Xu
On Fri, Sep 13, 2024 at 07:05:41PM -0300, Fabiano Rosas wrote: > There are two qemu_loadvm_state_cleanup() calls that were introduced > when qemu_loadvm_state_setup() was still called before loading the > configuration section, so there was state to be cleaned up if the > header checks failed. > >

[PATCH 1/2] migration/savevm: Remove extra load cleanup calls

2024-09-13 Thread Fabiano Rosas
There are two qemu_loadvm_state_cleanup() calls that were introduced when qemu_loadvm_state_setup() was still called before loading the configuration section, so there was state to be cleaned up if the header checks failed. However, commit 9e14b84908 ("migration/savevm: load_header before load_set