Re: [PATCH 1/2] memattrs: Get rid of bit fields

Hi CLEMENT, > > It still raises the size to 8 bytes but saves spare space, like: > > > > typedef struct MemTxAttrs { > > unsigned int secure:1; > > unsigned int space:2; > > unsigned int user:1; > > unsigned int memory:1; > > unsigned int requester_id:16; > > unsigned

Re: [PATCH 1/2] memattrs: Get rid of bit fields

On 1/20/25 17:38, Zhao Liu wrote: Thanks for the reminder, yes it is currently full. I found I missed a commnet from Paolo [*], that he suggested only convert `unspecified` to a bool. My bad :-( It still raises the size to 8 bytes but saves spare space, like: typedef struct MemTxAttrs { un

Re: [PATCH 1/2] memattrs: Get rid of bit fields

Hi, On 20/01/2025 17:38, Zhao Liu wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > > Hi Peter, > >>> /* >>>* PID (PCI PASID) support: Limited to 8 bits process identifier. >>

Re: [PATCH 1/2] memattrs: Get rid of bit fields

Hi Peter, > > /* > > * PID (PCI PASID) support: Limited to 8 bits process identifier. > > */ > > -unsigned int pid:8; > > -} MemTxAttrs; > > +uint8_t pid; > > + > > +/* Requester ID (for MSI for example) */ > > +uint16_t requester_id; > > +} QEMU_PACKED MemTxAttrs;