Re: [PATCH 1/2] isa/piix4: Resolve RTCState attribute

2022-02-05 Thread Philippe Mathieu-Daudé via
On 5/2/22 19:53, Peter Maydell wrote: On Sat, 5 Feb 2022 at 18:05, Bernhard Beschow wrote: Assuming that mc146818_rtc_init() is "syntactic sugar" for code that could be converted into configuration in the future, this patch is a step towards this future by freeing piix4 to care about the inner

Re: [PATCH 1/2] isa/piix4: Resolve RTCState attribute

2022-02-05 Thread Peter Maydell
On Sat, 5 Feb 2022 at 18:05, Bernhard Beschow wrote: > > Assuming that mc146818_rtc_init() is "syntactic sugar" for code that could > be converted into configuration in the future, this patch is a step towards > this future by freeing piix4 to care about the inner details of mc146818. > > Furtherm

[PATCH 1/2] isa/piix4: Resolve RTCState attribute

2022-02-05 Thread Bernhard Beschow
Assuming that mc146818_rtc_init() is "syntactic sugar" for code that could be converted into configuration in the future, this patch is a step towards this future by freeing piix4 to care about the inner details of mc146818. Furthermore, by reusing mc146818_rtc_init(), piix4's code becomes more ho