Re: [PATCH 1/2] iotests: Improve and rename test 291 to qemu-img-bitmap

2021-07-09 Thread Eric Blake
On Fri, Jul 09, 2021 at 04:49:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 09.07.2021 16:16, Eric Blake wrote: > > On Fri, Jul 09, 2021 at 09:33:50AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > > +++ b/tests/qemu-iotests/tests/qemu-img-bitmaps > > > > > > +echo > > > > +echo "=== Ch

Re: [PATCH 1/2] iotests: Improve and rename test 291 to qemu-img-bitmap

2021-07-09 Thread Vladimir Sementsov-Ogievskiy
09.07.2021 16:16, Eric Blake wrote: On Fri, Jul 09, 2021 at 09:33:50AM +0300, Vladimir Sementsov-Ogievskiy wrote: +++ b/tests/qemu-iotests/tests/qemu-img-bitmaps +echo +echo "=== Check handling of inconsistent bitmap ===" +echo + +$QEMU_IO -c abort "$TEST_IMG" 2>/dev/null +$QEMU_IMG bitmap --

Re: [PATCH 1/2] iotests: Improve and rename test 291 to qemu-img-bitmap

2021-07-09 Thread Eric Blake
On Fri, Jul 09, 2021 at 09:33:50AM +0300, Vladimir Sementsov-Ogievskiy wrote: > > +++ b/tests/qemu-iotests/tests/qemu-img-bitmaps > > +echo > > +echo "=== Check handling of inconsistent bitmap ===" > > +echo > > + > > +$QEMU_IO -c abort "$TEST_IMG" 2>/dev/null > > +$QEMU_IMG bitmap --add "$TEST_IM

Re: [PATCH 1/2] iotests: Improve and rename test 291 to qemu-img-bitmap

2021-07-08 Thread Vladimir Sementsov-Ogievskiy
08.07.2021 04:30, Eric Blake wrote: Enhance the test to demonstrate behavior of qemu-img with a qcow2 image containing an inconsistent bitmap, and rename it now that we support useful iotest names. While at it, fix a missing newline in the error message thus exposed. Signed-off-by: Eric Blake

[PATCH 1/2] iotests: Improve and rename test 291 to qemu-img-bitmap

2021-07-07 Thread Eric Blake
Enhance the test to demonstrate behavior of qemu-img with a qcow2 image containing an inconsistent bitmap, and rename it now that we support useful iotest names. While at it, fix a missing newline in the error message thus exposed. Signed-off-by: Eric Blake --- block/dirty-bitmap.c