Re: [PATCH 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-09 Thread Markus Armbruster
Klaus Jensen writes: > On Nov 9 13:36, Markus Armbruster wrote: >> Klaus Jensen writes: >> >> > From: Klaus Jensen >> > >> > Make nvme_check_constraints() return an int and fix incorrect use of >> > errp/local_err. >> > >> > Signed-off-by: Klaus Jensen >> >> One more question: what exactly

Re: [PATCH 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-09 Thread Klaus Jensen
On Nov 9 13:36, Markus Armbruster wrote: > Klaus Jensen writes: > > > From: Klaus Jensen > > > > Make nvme_check_constraints() return an int and fix incorrect use of > > errp/local_err. > > > > Signed-off-by: Klaus Jensen > > One more question: what exactly do you mean by "incorrect use of >

Re: [PATCH 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-09 Thread Markus Armbruster
Klaus Jensen writes: > From: Klaus Jensen > > Make nvme_check_constraints() return an int and fix incorrect use of > errp/local_err. > > Signed-off-by: Klaus Jensen One more question: what exactly do you mean by "incorrect use of errp/local_err"? Is it incorrect in the sense of "behaves badly

Re: [PATCH 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-09 Thread Klaus Jensen
On Nov 9 13:29, Markus Armbruster wrote: > Klaus Jensen writes: > > > From: Klaus Jensen > > > > Make nvme_check_constraints() return an int and fix incorrect use of > > errp/local_err. > > > > Signed-off-by: Klaus Jensen > > --- > > hw/nvme/ctrl.c | 48 +++

Re: [PATCH 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-09 Thread Markus Armbruster
Klaus Jensen writes: > From: Klaus Jensen > > Make nvme_check_constraints() return an int and fix incorrect use of > errp/local_err. > > Signed-off-by: Klaus Jensen > --- > hw/nvme/ctrl.c | 48 +++- > 1 file changed, 23 insertions(+), 25 deletions(-)

[PATCH 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-09 Thread Klaus Jensen
From: Klaus Jensen Make nvme_check_constraints() return an int and fix incorrect use of errp/local_err. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 48 +++- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme