Re: [PATCH 1/2] hw/mips: bootloader: Fix write_ulong

2021-12-05 Thread Jiaxun Yang
在2021年12月2日十二月 下午6:01,Philippe Mathieu-Daudé写道: > On 12/2/21 11:51, Jiaxun Yang wrote: >> 在2021年11月30日十一月 下午9:52,Philippe Mathieu-Daudé写道: >>> On 11/30/21 22:17, Jiaxun Yang wrote: bl_gen_write_ulong uses sd for both 32 and 64 bit CPU, while sd is illegal on 32 bit CPUs. Repl

Re: [PATCH 1/2] hw/mips: bootloader: Fix write_ulong

2021-12-02 Thread Philippe Mathieu-Daudé
On 12/2/21 11:51, Jiaxun Yang wrote: > 在2021年11月30日十一月 下午9:52,Philippe Mathieu-Daudé写道: >> On 11/30/21 22:17, Jiaxun Yang wrote: >>> bl_gen_write_ulong uses sd for both 32 and 64 bit CPU, >>> while sd is illegal on 32 bit CPUs. >>> >>> Replace sd with sw on 32bit CPUs. >>> >>> Fixes: 3ebbf86 ("hw/m

Re: [PATCH 1/2] hw/mips: bootloader: Fix write_ulong

2021-12-02 Thread Jiaxun Yang
在2021年11月30日十一月 下午9:52,Philippe Mathieu-Daudé写道: > On 11/30/21 22:17, Jiaxun Yang wrote: >> bl_gen_write_ulong uses sd for both 32 and 64 bit CPU, >> while sd is illegal on 32 bit CPUs. >> >> Replace sd with sw on 32bit CPUs. >> >> Fixes: 3ebbf86 ("hw/mips: Add a bootloader helper") >> Signed-

Re: [PATCH 1/2] hw/mips: bootloader: Fix write_ulong

2021-11-30 Thread Philippe Mathieu-Daudé
On 11/30/21 22:17, Jiaxun Yang wrote: > bl_gen_write_ulong uses sd for both 32 and 64 bit CPU, > while sd is illegal on 32 bit CPUs. > > Replace sd with sw on 32bit CPUs. > > Fixes: 3ebbf86 ("hw/mips: Add a bootloader helper") > Signed-off-by: Jiaxun Yang > --- > Should be backported to 6.0 onwa

[PATCH 1/2] hw/mips: bootloader: Fix write_ulong

2021-11-30 Thread Jiaxun Yang
bl_gen_write_ulong uses sd for both 32 and 64 bit CPU, while sd is illegal on 32 bit CPUs. Replace sd with sw on 32bit CPUs. Fixes: 3ebbf86 ("hw/mips: Add a bootloader helper") Signed-off-by: Jiaxun Yang --- Should be backported to 6.0 onwards. --- hw/mips/bootloader.c | 6 +- 1 file change