Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-19 Thread Alexander Bulekov
On 210319 1026, Paolo Bonzini wrote: > On 19/03/21 06:53, Markus Armbruster wrote: > > I guess this is a reproducer. Please also describe actual and expected > > result. Same for PATCH 2. > > Isn't it in the patch itself? > > Alexander, I think these reproducers are self-contained enough (no wr

Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-19 Thread Alexander Bulekov
On 210319 1054, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 19/03/21 06:53, Markus Armbruster wrote: > >> I guess this is a reproducer. Please also describe actual and expected > >> result. Same for PATCH 2. > > > > Isn't it in the patch itself? > > A commit message should tell m

Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-19 Thread Paolo Bonzini
On 19/03/21 10:54, Markus Armbruster wrote: A commit message should tell me what the patch is trying to accomplish. This commit message's title tells me it's a test for a CVE. Okay. The body additionally gives me the reproducer. To be useful, a reproducer needs to come with actual and expecte

Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-19 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/03/21 06:53, Markus Armbruster wrote: >> I guess this is a reproducer. Please also describe actual and expected >> result. Same for PATCH 2. > > Isn't it in the patch itself? A commit message should tell me what the patch is trying to accomplish. This commit mess

Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-19 Thread Paolo Bonzini
On 19/03/21 06:53, Markus Armbruster wrote: I guess this is a reproducer. Please also describe actual and expected result. Same for PATCH 2. Isn't it in the patch itself? Alexander, I think these reproducers are self-contained enough (no writes to PCI configuration space to set up the devic

Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-18 Thread Markus Armbruster
Alexander Bulekov writes: > dd if=/dev/zero of=/tmp/fda.img bs=1024 count=1440 > cat << EOF | ./qemu-system-i386 -nographic -m 512M -nodefaults \ > -accel qtest -fda /tmp/fda.img -qtest stdio > outw 0x3f4 0x0500 > outb 0x3f5 0x00 > outb 0x3f5 0x00 > outw 0x3f4 0x00 > outb 0x3f5 0x00 > outw 0x3f1

[PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-18 Thread Alexander Bulekov
dd if=/dev/zero of=/tmp/fda.img bs=1024 count=1440 cat << EOF | ./qemu-system-i386 -nographic -m 512M -nodefaults \ -accel qtest -fda /tmp/fda.img -qtest stdio outw 0x3f4 0x0500 outb 0x3f5 0x00 outb 0x3f5 0x00 outw 0x3f4 0x00 outb 0x3f5 0x00 outw 0x3f1 0x0400 outw 0x3f4 0x0 outw 0x3f4 0x00 outb 0x3