Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Mon, Jan 29, 2024 at 10:41:38AM +, Peter Maydell wrote: > On Mon, 29 Jan 2024 at 09:47, Samuel Tardieu wrote: > > However, this is not what QEMU has been using as far as I can see, > > as S-o-b tend to stay in their original positions. I even opened > > an issue on b4 a few weeks ago becaus

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Mon, 29 Jan 2024 at 09:47, Samuel Tardieu wrote: > However, this is not what QEMU has been using as far as I can see, > as S-o-b tend to stay in their original positions. I even opened > an issue on b4 a few weeks ago because of this > , and I reverted to

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

Daniel P. Berrangé writes: Is there any requirement for the order of tags? My previous understanding was that if the Reviewed-by/Tested-by tags were obtained by the author within his company, then those tags should be placed before the signed-off-by of the author. If the Reviewed-by/ Test

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Sat, Jan 27, 2024 at 10:36:24PM +0800, Zhao Liu wrote: > Hi Daniel, > > On Thu, Nov 23, 2023 at 11:40:25AM +, Daniel P. Berrangé wrote: > > +Multiple authorship > > +~~~ > > + > > +It is not uncommon for a patch to have contributions from multiple > > +authors. In such a sce

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

Hi Daniel, On Thu, Nov 23, 2023 at 11:40:25AM +, Daniel P. Berrangé wrote: > Date: Thu, 23 Nov 2023 11:40:25 + > From: "Daniel P. Berrangé" > Subject: [PATCH 1/2] docs: introduce dedicated page about code provenance / > sign-off > > Currently we have a

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Fri, Nov 24, 2023 at 12:11:30PM +0100, Philippe Mathieu-Daudé wrote: > On 23/11/23 18:33, Michael S. Tsirkin wrote: > > On Thu, Nov 23, 2023 at 05:16:45PM +, Daniel P. Berrangé wrote: > > > On Thu, Nov 23, 2023 at 09:25:13AM -0500, Michael S. Tsirkin wrote: > > > > On Thu, Nov 23, 2023 at 11

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On 23/11/23 18:33, Michael S. Tsirkin wrote: On Thu, Nov 23, 2023 at 05:16:45PM +, Daniel P. Berrangé wrote: On Thu, Nov 23, 2023 at 09:25:13AM -0500, Michael S. Tsirkin wrote: On Thu, Nov 23, 2023 at 11:40:25AM +, Daniel P. Berrangé wrote: Currently we have a short paragraph saying th

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

Am 23.11.2023 um 18:16 hat Daniel P. Berrangé geschrieben: > > Suggested-by is also common. > > > > As long as we are here, let's document Fixes: and Cc: ? > > The submitting-a-patch doc covers more general commit message information. > I think this doc just ought to focus on tags that identify h

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, Nov 23, 2023 at 05:08:46PM +, Daniel P. Berrangé wrote: > On Thu, Nov 23, 2023 at 12:58:18PM +0100, Philippe Mathieu-Daudé wrote: > > On 23/11/23 12:40, Daniel P. Berrangé wrote: > > > Currently we have a short paragraph saying that patches must include > > > a Signed-off-by line, and m

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, Nov 23, 2023 at 05:16:45PM +, Daniel P. Berrangé wrote: > On Thu, Nov 23, 2023 at 09:25:13AM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 23, 2023 at 11:40:25AM +, Daniel P. Berrangé wrote: > > > Currently we have a short paragraph saying that patches must include > > > a Signed

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, Nov 23, 2023 at 09:25:13AM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 23, 2023 at 11:40:25AM +, Daniel P. Berrangé wrote: > > Currently we have a short paragraph saying that patches must include > > a Signed-off-by line, and merely link to the kernel documentation. > > The linked ke

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, Nov 23, 2023 at 02:16:36PM +0100, Kevin Wolf wrote: > Am 23.11.2023 um 12:40 hat Daniel P. Berrangé geschrieben: > > Currently we have a short paragraph saying that patches must include > > a Signed-off-by line, and merely link to the kernel documentation. > > The linked kernel docs have al

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, Nov 23, 2023 at 01:01:00PM +, Peter Maydell wrote: > On Thu, 23 Nov 2023 at 11:40, Daniel P. Berrangé wrote: > > > > Currently we have a short paragraph saying that patches must include > > a Signed-off-by line, and merely link to the kernel documentation. > > The linked kernel docs ha

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, Nov 23, 2023 at 12:58:18PM +0100, Philippe Mathieu-Daudé wrote: > On 23/11/23 12:40, Daniel P. Berrangé wrote: > > Currently we have a short paragraph saying that patches must include > > a Signed-off-by line, and merely link to the kernel documentation. > > The linked kernel docs have alot

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, Nov 23, 2023 at 11:40:25AM +, Daniel P. Berrangé wrote: > Currently we have a short paragraph saying that patches must include > a Signed-off-by line, and merely link to the kernel documentation. > The linked kernel docs have alot of content beyond the part about > sign-off an thus is m

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, Nov 23, 2023 at 11:40:25AM +, Daniel P. Berrangé wrote: > Currently we have a short paragraph saying that patches must include > a Signed-off-by line, and merely link to the kernel documentation. > The linked kernel docs have alot of content beyond the part about > sign-off an thus is m

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

Am 23.11.2023 um 12:40 hat Daniel P. Berrangé geschrieben: > Currently we have a short paragraph saying that patches must include > a Signed-off-by line, and merely link to the kernel documentation. > The linked kernel docs have alot of content beyond the part about > sign-off an thus is misleading

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On Thu, 23 Nov 2023 at 11:40, Daniel P. Berrangé wrote: > > Currently we have a short paragraph saying that patches must include > a Signed-off-by line, and merely link to the kernel documentation. > The linked kernel docs have alot of content beyond the part about "a lot" > sign-off an thus is

Re: [PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

On 23/11/23 12:40, Daniel P. Berrangé wrote: Currently we have a short paragraph saying that patches must include a Signed-off-by line, and merely link to the kernel documentation. The linked kernel docs have alot of content beyond the part about sign-off an thus is misleading/distracting to QEMU

[PATCH 1/2] docs: introduce dedicated page about code provenance / sign-off

Currently we have a short paragraph saying that patches must include a Signed-off-by line, and merely link to the kernel documentation. The linked kernel docs have alot of content beyond the part about sign-off an thus is misleading/distracting to QEMU contributors. This introduces a dedicated 'co