Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Kashyap Chamarthy
On Mon, Nov 22, 2021 at 03:01:58PM +0100, Thomas Huth wrote: > On 22/11/2021 14.53, Peter Maydell wrote: [...] > > I don't think we should be recommending to new contributors that > > they do things that established contributors generally do not do. > > The document has enough "things you should

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 22/11/2021 14.53, Peter Maydell wrote: On Mon, 22 Nov 2021 at 13:30, Thomas Huth wrote: On 22/11/2021 14.25, Peter Maydell wrote: On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: What about simply replacing it with a new sentence below the bullet list, saying: "Please also use a spell c

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Peter Maydell
On Mon, 22 Nov 2021 at 13:30, Thomas Huth wrote: > > On 22/11/2021 14.25, Peter Maydell wrote: > > On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: > >> What about simply replacing it with a new sentence below the bullet list, > >> saying: > >> > >> "Please also use a spell checker like `codespel

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 22/11/2021 14.33, Daniel P. Berrangé wrote: On Mon, Nov 22, 2021 at 02:30:10PM +0100, Thomas Huth wrote: On 22/11/2021 14.25, Peter Maydell wrote: On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: What about simply replacing it with a new sentence below the bullet list, saying: "Please als

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Daniel P . Berrangé
On Mon, Nov 22, 2021 at 02:30:10PM +0100, Thomas Huth wrote: > On 22/11/2021 14.25, Peter Maydell wrote: > > On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: > > > What about simply replacing it with a new sentence below the bullet list, > > > saying: > > > > > > "Please also use a spell checker

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 22/11/2021 14.25, Peter Maydell wrote: On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: What about simply replacing it with a new sentence below the bullet list, saying: "Please also use a spell checker like `codespell https://github.com/codespell-project/codespell` with your patches" How

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Peter Maydell
On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: > What about simply replacing it with a new sentence below the bullet list, > saying: > > "Please also use a spell checker like `codespell > https://github.com/codespell-project/codespell` with your patches" How many regular contributors actually d

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Kashyap Chamarthy
On Mon, Nov 22, 2021 at 01:36:53PM +0100, Thomas Huth wrote: > On 22/11/2021 13.19, Kashyap Chamarthy wrote: [...] > > I kept that because an explicit reminder about spell-check is useful; > > it's easy to forget. Another option is to retain the line, but replace > > "See also:" with "And:". No

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 22/11/2021 13.19, Kashyap Chamarthy wrote: On Mon, Nov 22, 2021 at 11:36:54AM +0100, Thomas Huth wrote: On 22/11/2021 11.20, Kashyap Chamarthy wrote: On Mon, Nov 22, 2021 at 10:51:15AM +0100, Thomas Huth wrote: [...] I'll add the link to https://wiki.qemu.org/Contribute/SpellCheck again.

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Kashyap Chamarthy
On Mon, Nov 22, 2021 at 11:36:54AM +0100, Thomas Huth wrote: > On 22/11/2021 11.20, Kashyap Chamarthy wrote: > > On Mon, Nov 22, 2021 at 10:51:15AM +0100, Thomas Huth wrote: [...] > > > I'll add the link to https://wiki.qemu.org/Contribute/SpellCheck again. > > > > Please don't -- I intentionall

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 22/11/2021 11.20, Kashyap Chamarthy wrote: On Mon, Nov 22, 2021 at 10:51:15AM +0100, Thomas Huth wrote: On 19/11/2021 20.31, Kashyap Chamarthy wrote: I completely botched up the merged[0] rST conversion of this document by accidentally dropping entire hunks (!) of text. :-( I made it very h

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Kashyap Chamarthy
On Mon, Nov 22, 2021 at 10:51:15AM +0100, Thomas Huth wrote: > On 19/11/2021 20.31, Kashyap Chamarthy wrote: > > I completely botched up the merged[0] rST conversion of this document by > > accidentally dropping entire hunks (!) of text. :-( I made it very hard > > for reviewers to spot it, as the

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 19/11/2021 20.31, Kashyap Chamarthy wrote: I completely botched up the merged[0] rST conversion of this document by accidentally dropping entire hunks (!) of text. :-( I made it very hard for reviewers to spot it, as the omitted text was buried deep in the document. To fix my hatchet job, I

[PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-19 Thread Kashyap Chamarthy
I completely botched up the merged[0] rST conversion of this document by accidentally dropping entire hunks (!) of text. :-( I made it very hard for reviewers to spot it, as the omitted text was buried deep in the document. To fix my hatchet job, I reconverted the "SubmitAPatch" wiki[1] page from