Re: [PATCH 1/2] block/rbd: fix handling of holes in .bdrv_co_block_status

2022-01-12 Thread Peter Lieven
> Am 12.01.2022 um 22:06 schrieb Ilya Dryomov : > > On Wed, Jan 12, 2022 at 9:39 PM Peter Lieven wrote: >> >>> Am 12.01.22 um 10:05 schrieb Ilya Dryomov: >>> On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote: the assumption that we can't hit a hole if we do not diff against a sn

Re: [PATCH 1/2] block/rbd: fix handling of holes in .bdrv_co_block_status

2022-01-12 Thread Ilya Dryomov
On Wed, Jan 12, 2022 at 9:39 PM Peter Lieven wrote: > > Am 12.01.22 um 10:05 schrieb Ilya Dryomov: > > On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote: > >> the assumption that we can't hit a hole if we do not diff against a > >> snapshot was wrong. > >> > >> We can see a hole in an image if

Re: [PATCH 1/2] block/rbd: fix handling of holes in .bdrv_co_block_status

2022-01-12 Thread Peter Lieven
Am 12.01.22 um 10:05 schrieb Ilya Dryomov: > On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote: >> the assumption that we can't hit a hole if we do not diff against a snapshot >> was wrong. >> >> We can see a hole in an image if we diff against base if there exists an >> older snapshot >> of t

Re: [PATCH 1/2] block/rbd: fix handling of holes in .bdrv_co_block_status

2022-01-12 Thread Ilya Dryomov
On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote: > > the assumption that we can't hit a hole if we do not diff against a snapshot > was wrong. > > We can see a hole in an image if we diff against base if there exists an > older snapshot > of the image and we have discarded blocks in the imag

[PATCH 1/2] block/rbd: fix handling of holes in .bdrv_co_block_status

2022-01-10 Thread Peter Lieven
the assumption that we can't hit a hole if we do not diff against a snapshot was wrong. We can see a hole in an image if we diff against base if there exists an older snapshot of the image and we have discarded blocks in the image where the snapshot has data. Fixes: 0347a8fd4c3faaedf119be04c19