Re: [PATCH 1/2] backends/dbus-vmstate: Fix short read error handling

2021-03-09 Thread Laurent Vivier
Le 26/01/2021 à 13:42, Markus Armbruster a écrit : > When dbus_vmstate_post_load() fails, it complains to stderr. Except > on short read, where it checks with g_return_val_if_fail(). This > fails silently if G_DISABLE_CHECKS is undefined (it should be), or > else pads the short read with uninitia

Re: [PATCH 1/2] backends/dbus-vmstate: Fix short read error handling

2021-01-26 Thread Marc-André Lureau
On Tue, Jan 26, 2021 at 4:43 PM Markus Armbruster wrote: > > When dbus_vmstate_post_load() fails, it complains to stderr. Except > on short read, where it checks with g_return_val_if_fail(). This > fails silently if G_DISABLE_CHECKS is undefined (it should be), or > else pads the short read with

[PATCH 1/2] backends/dbus-vmstate: Fix short read error handling

2021-01-26 Thread Markus Armbruster
When dbus_vmstate_post_load() fails, it complains to stderr. Except on short read, where it checks with g_return_val_if_fail(). This fails silently if G_DISABLE_CHECKS is undefined (it should be), or else pads the short read with uninitialized bytes. Replace g_return_val_if_fail() by a proper er