Re: [PATCH 1/1] vhost-scsi: fix usage of error_reportf_err()

2023-12-14 Thread Raphael Norwitz
> On Dec 13, 2023, at 7:31 PM, Dongli Zhang wrote: > > It is required to use error_report() instead of error_reportf_err(), if the > prior function does not take local_err as the argument. As a result, the > local_err is always NULL and segment fault may happen. > > vhost_scsi_start() > -> vhost

Re: [PATCH 1/1] vhost-scsi: fix usage of error_reportf_err()

2023-12-13 Thread Li Feng
> On Dec 14, 2023, at 08:31, Dongli Zhang wrote: > > It is required to use error_report() instead of error_reportf_err(), if the > prior function does not take local_err as the argument. As a result, the > local_err is always NULL and segment fault may happen. > > vhost_scsi_start() > -> vhost_

[PATCH 1/1] vhost-scsi: fix usage of error_reportf_err()

2023-12-13 Thread Dongli Zhang
It is required to use error_report() instead of error_reportf_err(), if the prior function does not take local_err as the argument. As a result, the local_err is always NULL and segment fault may happen. vhost_scsi_start() -> vhost_scsi_set_endpoint(s) --> does not allocate local_err -> error_repo