Re: [PATCH 1/1] target/riscv: Clear vstart_qe_zero flag

2024-02-17 Thread Richard Henderson
On 2/17/24 00:53, Daniel Henrique Barboza wrote: This patch is replacing mark_vs_dirty() with finalize(), that does call mark_vs_dirty() and set start_eq_zero = true, but it's missing the start_eq_zero update for store functions because of these ifs. We could just remove these ifs and finalize

Re: [PATCH 1/1] target/riscv: Clear vstart_qe_zero flag

2024-02-17 Thread Daniel Henrique Barboza
Richard, On 12/14/23 08:18, Ivan Klokov wrote: The vstart_qe_zero flag is set at the beginning of the translation phase from the env->vstart variable. During the execution phase, some instructions may change env->vstart, but the flag remains the same as at the start of the block. With some comb

Re: [PATCH 1/1] target/riscv: Clear vstart_qe_zero flag

2023-12-14 Thread Daniel Henrique Barboza
On 12/14/23 08:18, Ivan Klokov wrote: The vstart_qe_zero flag is set at the beginning of the translation phase from the env->vstart variable. During the execution phase, some instructions may change env->vstart, but the flag remains the same as at the start of the block. With some combinations

[PATCH 1/1] target/riscv: Clear vstart_qe_zero flag

2023-12-14 Thread Ivan Klokov
The vstart_qe_zero flag is set at the beginning of the translation phase from the env->vstart variable. During the execution phase, some instructions may change env->vstart, but the flag remains the same as at the start of the block. With some combinations of instructions this causes an illegal ins