Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-25 Thread David Gibson
On Tue, Aug 25, 2020 at 08:27:28AM +0200, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > Cc'ing Markus > > > > On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: > >> We do not implement hotplug in the vscsi bus, but we forgot to > >> tell qdev about it. The result is that users

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-24 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Cc'ing Markus > > On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: >> We do not implement hotplug in the vscsi bus, but we forgot to >> tell qdev about it. The result is that users are able to hotplug >> devices in the vscsi bus, the devices appear in qdev, but

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-21 Thread Daniel Henrique Barboza
On 8/21/20 11:12 AM, Philippe Mathieu-Daudé wrote: On 8/21/20 4:08 PM, Daniel Henrique Barboza wrote: On 8/21/20 8:08 AM, Philippe Mathieu-Daudé wrote: Cc'ing Markus On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: We do not implement hotplug in the vscsi bus, but we forgot to tell qde

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-21 Thread Philippe Mathieu-Daudé
On 8/21/20 4:08 PM, Daniel Henrique Barboza wrote: > > > On 8/21/20 8:08 AM, Philippe Mathieu-Daudé wrote: >> Cc'ing Markus >> >> On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: >>> We do not implement hotplug in the vscsi bus, but we forgot to >>> tell qdev about it. The result is that users

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-21 Thread Daniel Henrique Barboza
On 8/21/20 8:08 AM, Philippe Mathieu-Daudé wrote: Cc'ing Markus On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: We do not implement hotplug in the vscsi bus, but we forgot to tell qdev about it. The result is that users are able to hotplug devices in the vscsi bus, the devices appear in q

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-21 Thread Philippe Mathieu-Daudé
Cc'ing Markus On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: > We do not implement hotplug in the vscsi bus, but we forgot to > tell qdev about it. The result is that users are able to hotplug > devices in the vscsi bus, the devices appear in qdev, but they > aren't usable by the guest OS unle

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-20 Thread David Gibson
On Thu, Aug 20, 2020 at 04:06:35PM -0300, Daniel Henrique Barboza wrote: > We do not implement hotplug in the vscsi bus, but we forgot to > tell qdev about it. The result is that users are able to hotplug > devices in the vscsi bus, the devices appear in qdev, but they > aren't usable by the guest

[PATCH 1/1] spapr_vscsi: do not allow device hotplug

2020-08-20 Thread Daniel Henrique Barboza
We do not implement hotplug in the vscsi bus, but we forgot to tell qdev about it. The result is that users are able to hotplug devices in the vscsi bus, the devices appear in qdev, but they aren't usable by the guest OS unless the user reboots it first. Setting qbus hotplug_handler to NULL will t