Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > The -device JSON syntax impl leaks a reference on the created > DeviceState instance. As a result when you hot-unplug the > device, the device_finalize method won't be called and thus > it will fail to emit the required DEVICE_DELETED event. > > A 'json-cli' feature w

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Laurent Vivier
On 05/01/2022 16:18, Daniel P. Berrangé wrote: On Wed, Jan 05, 2022 at 04:00:54PM +0100, Laurent Vivier wrote: On 05/01/2022 15:55, Daniel P. Berrangé wrote: On Wed, Jan 05, 2022 at 03:49:12PM +0100, Laurent Vivier wrote: On 05/01/2022 13:38, Daniel P. Berrangé wrote: The -device JSON syntax

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Thomas Huth
On 05/01/2022 16.18, Daniel P. Berrangé wrote: On Wed, Jan 05, 2022 at 04:00:54PM +0100, Laurent Vivier wrote: On 05/01/2022 15:55, Daniel P. Berrangé wrote: On Wed, Jan 05, 2022 at 03:49:12PM +0100, Laurent Vivier wrote: On 05/01/2022 13:38, Daniel P. Berrangé wrote: The -device JSON syntax

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Daniel P . Berrangé
On Wed, Jan 05, 2022 at 04:00:54PM +0100, Laurent Vivier wrote: > On 05/01/2022 15:55, Daniel P. Berrangé wrote: > > On Wed, Jan 05, 2022 at 03:49:12PM +0100, Laurent Vivier wrote: > > > On 05/01/2022 13:38, Daniel P. Berrangé wrote: > > > > The -device JSON syntax impl leaks a reference on the cre

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Laurent Vivier
On 05/01/2022 13:38, Daniel P. Berrangé wrote: The -device JSON syntax impl leaks a reference on the created DeviceState instance. As a result when you hot-unplug the device, the device_finalize method won't be called and thus it will fail to emit the required DEVICE_DELETED event. A 'json-cli'

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Laurent Vivier
On 05/01/2022 15:55, Daniel P. Berrangé wrote: On Wed, Jan 05, 2022 at 03:49:12PM +0100, Laurent Vivier wrote: On 05/01/2022 13:38, Daniel P. Berrangé wrote: The -device JSON syntax impl leaks a reference on the created DeviceState instance. As a result when you hot-unplug the device, the devic

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Daniel P . Berrangé
On Wed, Jan 05, 2022 at 03:49:12PM +0100, Laurent Vivier wrote: > On 05/01/2022 13:38, Daniel P. Berrangé wrote: > > The -device JSON syntax impl leaks a reference on the created > > DeviceState instance. As a result when you hot-unplug the > > device, the device_finalize method won't be called and

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Ján Tomko
On a Wednesday in 2022, Daniel P. Berrangé wrote: The -device JSON syntax impl leaks a reference on the created DeviceState instance. As a result when you hot-unplug the device, the device_finalize method won't be called and thus it will fail to emit the required DEVICE_DELETED event. A 'json-cl

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Thomas Huth
On 05/01/2022 13.38, Daniel P. Berrangé wrote: The -device JSON syntax impl leaks a reference on the created DeviceState instance. As a result when you hot-unplug the device, the device_finalize method won't be called and thus it will fail to emit the required DEVICE_DELETED event. A 'json-cli'

[PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Daniel P . Berrangé
The -device JSON syntax impl leaks a reference on the created DeviceState instance. As a result when you hot-unplug the device, the device_finalize method won't be called and thus it will fail to emit the required DEVICE_DELETED event. A 'json-cli' feature was previously added against the 'device_