Re: [PATCH 1/1] meson: Enable -Wshadow=local

2023-10-26 Thread Daniel P . Berrangé
On Thu, Oct 26, 2023 at 07:58:42AM +0200, Philippe Mathieu-Daudé wrote: > On 26/10/23 07:31, Markus Armbruster wrote: > > Local variables shadowing other local variables or parameters make the > > code needlessly hard to understand. Bugs love to hide in such code. > > Evidence: commit bbde656263d

Re: [PATCH 1/1] meson: Enable -Wshadow=local

2023-10-25 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 26/10/23 08:12, Thomas Huth wrote: >> On 26/10/2023 07.58, Philippe Mathieu-Daudé wrote: [...] >>> $ ../configure >>> The Meson build system >>> Version: 1.2.1 >>> Build type: native build >>> Project name: qemu >>> Project version: 8.1.50 >>> C compiler for

Re: [PATCH 1/1] meson: Enable -Wshadow=local

2023-10-25 Thread Philippe Mathieu-Daudé
On 26/10/23 08:12, Thomas Huth wrote: On 26/10/2023 07.58, Philippe Mathieu-Daudé wrote: On 26/10/23 07:31, Markus Armbruster wrote: Local variables shadowing other local variables or parameters make the code needlessly hard to understand.  Bugs love to hide in such code. Evidence: commit bbde6

Re: [PATCH 1/1] meson: Enable -Wshadow=local

2023-10-25 Thread Thomas Huth
On 26/10/2023 07.58, Philippe Mathieu-Daudé wrote: On 26/10/23 07:31, Markus Armbruster wrote: Local variables shadowing other local variables or parameters make the code needlessly hard to understand.  Bugs love to hide in such code. Evidence: commit bbde656263d (migration/rdma: Fix save_page m

Re: [PATCH 1/1] meson: Enable -Wshadow=local

2023-10-25 Thread Philippe Mathieu-Daudé
On 26/10/23 07:31, Markus Armbruster wrote: Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: commit bbde656263d (migration/rdma: Fix save_page method to fail on polling error). Enable -Wshadow=lo

Re: [PATCH 1/1] meson: Enable -Wshadow=local

2023-10-25 Thread Thomas Huth
On 26/10/2023 07.51, Warner Losh wrote: On Wed, Oct 25, 2023, 11:31 PM Markus Armbruster > wrote: Local variables shadowing other local variables or parameters make the code needlessly hard to understand.  Bugs love to hide in such code. Evidence: commit

Re: [PATCH 1/1] meson: Enable -Wshadow=local

2023-10-25 Thread Warner Losh
On Wed, Oct 25, 2023, 11:31 PM Markus Armbruster wrote: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Bugs love to hide in such code. > Evidence: commit bbde656263d (migration/rdma: Fix save_page method to > fail on polling error).

Re: [PATCH 1/1] meson: Enable -Wshadow=local

2023-10-25 Thread Thomas Huth
On 26/10/2023 07.31, Markus Armbruster wrote: Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: commit bbde656263d (migration/rdma: Fix save_page method to fail on polling error). Enable -Wshadow=

[PATCH 1/1] meson: Enable -Wshadow=local

2023-10-25 Thread Markus Armbruster
Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: commit bbde656263d (migration/rdma: Fix save_page method to fail on polling error). Enable -Wshadow=local to prevent such issues. Possible thanks t