Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-06-01 Thread John Snow
On Thu, Jun 1, 2023, 10:03 AM Niklas Cassel wrote: > On Wed, May 24, 2023 at 11:20:41AM -0400, John Snow wrote: > > On Wed, May 24, 2023, 4:17 AM Niklas Cassel wrote: > > > > > On Tue, May 23, 2023 at 10:35:56AM -0400, John Snow wrote: > > > > On Mon, May 22, 2023 at 5:16???PM Mateusz Albecki <

Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-06-01 Thread Niklas Cassel
On Wed, May 24, 2023 at 11:20:41AM -0400, John Snow wrote: > On Wed, May 24, 2023, 4:17 AM Niklas Cassel wrote: > > > On Tue, May 23, 2023 at 10:35:56AM -0400, John Snow wrote: > > > On Mon, May 22, 2023 at 5:16???PM Mateusz Albecki < > > mateusz.p.albe...@gmail.com> > > > wrote: > > > > > > > >

Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-05-24 Thread John Snow
On Wed, May 24, 2023, 4:17 AM Niklas Cassel wrote: > On Tue, May 23, 2023 at 10:35:56AM -0400, John Snow wrote: > > On Mon, May 22, 2023 at 5:16???PM Mateusz Albecki < > mateusz.p.albe...@gmail.com> > > wrote: > > > > > > Certainly seems like my patch is wrong as it will make the abort path > > e

Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-05-24 Thread Niklas Cassel
On Tue, May 23, 2023 at 10:35:56AM -0400, John Snow wrote: > On Mon, May 22, 2023 at 5:16???PM Mateusz Albecki > > wrote: > > > > Certainly seems like my patch is wrong as it will make the abort path > execute ide_cmd_done twice. During debug I came to the conclusion that > ide_cmd_done is not ca

Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-05-23 Thread John Snow
On Mon, May 22, 2023 at 5:16 PM Mateusz Albecki wrote: > > Certainly seems like my patch is wrong as it will make the abort path execute ide_cmd_done twice. During debug I came to the conclusion that ide_cmd_done is not called at all as I was getting timeouts on the driver side while waiting for D

Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-05-22 Thread Mateusz Albecki
Certainly seems like my patch is wrong as it will make the abort path execute ide_cmd_done twice. During debug I came to the conclusion that ide_cmd_done is not called at all as I was getting timeouts on the driver side while waiting for D2H FIS. I am still not sure how I was getting this behavior

Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-05-17 Thread John Snow
On Sun, Apr 16, 2023 at 6:29 PM Mateusz Albecki wrote: > > From: Mateusz Albecki > > Current code will not call ide_cmd_done when aborting the unsupported > command which will lead to the command timeout on the driver side instead > of getting a D2H FIS with ABRT indication. This can lead to prob

[PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-04-16 Thread Mateusz Albecki
From: Mateusz Albecki Current code will not call ide_cmd_done when aborting the unsupported command which will lead to the command timeout on the driver side instead of getting a D2H FIS with ABRT indication. This can lead to problems on the driver side as the spec mandates that device should ret