Re: [PATCH 1/1] hw/arm/sbsa-ref: Adding TPM support for ARM SBSA-Ref machine

2025-04-04 Thread Philippe Mathieu-Daudé
Hi Kun, On 3/3/25 23:55, Kun Qin wrote: Hi Leif & Peter, Thanks for the comments. I will address them in a v2 patch. Please also Cc me in your v2 :) Regards, Phil. Regards, Kun On Mon, Mar 3, 2025 at 12:44 PM Leif Lindholm mailto:leif.lindh...@oss.qualcomm.com>> wrote: Doh! Add

Re: [PATCH 1/1] hw/arm/sbsa-ref: Adding TPM support for ARM SBSA-Ref machine

2025-03-03 Thread Kun Qin
Hi Leif & Peter, Thanks for the comments. I will address them in a v2 patch. Regards, Kun On Mon, Mar 3, 2025 at 12:44 PM Leif Lindholm < leif.lindh...@oss.qualcomm.com> wrote: > Doh! Add the lists back in. (No idea how I dropped them off.) > > On Mon, 3 Mar 2025 at 17:02, Leif Lindholm > wrot

Re: [PATCH 1/1] hw/arm/sbsa-ref: Adding TPM support for ARM SBSA-Ref machine

2025-03-03 Thread Leif Lindholm
Doh! Add the lists back in. (No idea how I dropped them off.) On Mon, 3 Mar 2025 at 17:02, Leif Lindholm wrote: > > Hi Kun, > > Apologies for delay in responding - I was out last week. > I agree with this addition, since a TPM is a requirement for servers. > > However, to help simplify review, co

Re: [PATCH 1/1] hw/arm/sbsa-ref: Adding TPM support for ARM SBSA-Ref machine

2025-03-03 Thread Peter Maydell
On Tue, 25 Feb 2025 at 07:41, Kun Qin wrote: > > From: Kun Qin > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2625 > > This change aims to add a TPM device for SBSA ref machine. > > The implementation adds a TPM create routine during machine > initialization. > > The backend can be t

Re: [PATCH 1/1] hw/arm/sbsa-ref: Adding TPM support for ARM SBSA-Ref machine

2025-02-28 Thread Kun Qin
Hi Graeme, Thank you for your review. Could you please let me know if there is anything else I need to do or wait on before merging the change? Any input is appreciated. Regards, Kun On Thu, Feb 27, 2025 at 7:16 AM Graeme Gregory wrote: > > On 25/02/2025 07:41, Kun Qin wrote: > > From: Kun

Re: [PATCH 1/1] hw/arm/sbsa-ref: Adding TPM support for ARM SBSA-Ref machine

2025-02-27 Thread Graeme Gregory
On 25/02/2025 07:41, Kun Qin wrote: From: Kun Qin Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2625 This change aims to add a TPM device for SBSA ref machine. The implementation adds a TPM create routine during machine initialization. The backend can be the same as the rest of T

[PATCH 1/1] hw/arm/sbsa-ref: Adding TPM support for ARM SBSA-Ref machine

2025-02-25 Thread Kun Qin
From: Kun Qin Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2625 This change aims to add a TPM device for SBSA ref machine. The implementation adds a TPM create routine during machine initialization. The backend can be the same as the rest of TPM support, by using swtpm. Signed-off-