Re: [PATCH 1/1] e1000e: Fix tx/rx counters

2023-05-10 Thread Jason Wang
On Thu, May 11, 2023 at 2:54 AM Michael Tokarev wrote: > > 10.04.2023 18:27, timothee.coca...@gmail.com wrote: > > The bytes and packets counter registers are cleared on read. > > > > Copying the "total counter" registers to the "good counter" registers has > > side effects. > > If the "total" reg

Re: [PATCH 1/1] e1000e: Fix tx/rx counters

2023-05-10 Thread Michael Tokarev
10.04.2023 18:27, timothee.coca...@gmail.com wrote: The bytes and packets counter registers are cleared on read. Copying the "total counter" registers to the "good counter" registers has side effects. If the "total" register is never read by the OS, it only gets incremented. This leads to expone

Re: [PATCH 1/1] e1000e: Fix tx/rx counters

2023-05-09 Thread Jason Wang
在 2023/4/10 23:33, Akihiko Odaki 写道: On 2023/04/11 0:27, timothee.coca...@gmail.com wrote: The bytes and packets counter registers are cleared on read. Copying the "total counter" registers to the "good counter" registers has side effects. If the "total" register is never read by the OS, it

[PATCH 1/1] e1000e: Fix tx/rx counters

2023-04-10 Thread timothee . cocault
The bytes and packets counter registers are cleared on read. Copying the "total counter" registers to the "good counter" registers has side effects. If the "total" register is never read by the OS, it only gets incremented. This leads to exponential growth of the "good" register. This commit incr

Re: [PATCH 1/1] e1000e: Fix tx/rx counters

2023-04-10 Thread Akihiko Odaki
On 2023/04/11 0:27, timothee.coca...@gmail.com wrote: The bytes and packets counter registers are cleared on read. Copying the "total counter" registers to the "good counter" registers has side effects. If the "total" register is never read by the OS, it only gets incremented. This leads to expo