Re: [PATCH 1/1] disas/riscv: Guard dec->cfg dereference for host disassemble

2024-12-06 Thread LIU Zhiwei
On 2024/12/6 21:36, Richard Henderson wrote: On 12/5/24 22:39, LIU Zhiwei wrote: Both zcmt and zcmp are not compatible with Zcd, as they reuse some encodings from c.fsdsp. Ok, fair.  A comment about conflicts at that point may help. Ok. Zimop or Zcmop also overlap with other isa exten

Re: [PATCH 1/1] disas/riscv: Guard dec->cfg dereference for host disassemble

2024-12-06 Thread Richard Henderson
On 12/5/24 22:39, LIU Zhiwei wrote: Both zcmt and zcmp are not compatible with Zcd, as they reuse some encodings from c.fsdsp. Ok, fair. A comment about conflicts at that point may help. Zimop or Zcmop also overlap with other isa extensions, as they are maybe-ops. Other extensions such a

Re: [PATCH 1/1] disas/riscv: Guard dec->cfg dereference for host disassemble

2024-12-05 Thread LIU Zhiwei
On 2024/12/6 11:36, Richard Henderson wrote: On 12/5/24 21:24, LIU Zhiwei wrote: For riscv host, it will set dec->cfg to zero. Thus we shuld guard the dec->cfg deference for riscv host disassemble. And in general, we should only use dec->cfg for target in three cases: 1) For not incompatible

Re: [PATCH 1/1] disas/riscv: Guard dec->cfg dereference for host disassemble

2024-12-05 Thread Richard Henderson
On 12/5/24 21:24, LIU Zhiwei wrote: For riscv host, it will set dec->cfg to zero. Thus we shuld guard the dec->cfg deference for riscv host disassemble. And in general, we should only use dec->cfg for target in three cases: 1) For not incompatible encodings, such as zcmp/zcmt/zfinx. 2) For mayb

[PATCH 1/1] disas/riscv: Guard dec->cfg dereference for host disassemble

2024-12-05 Thread LIU Zhiwei
For riscv host, it will set dec->cfg to zero. Thus we shuld guard the dec->cfg deference for riscv host disassemble. And in general, we should only use dec->cfg for target in three cases: 1) For not incompatible encodings, such as zcmp/zcmt/zfinx. 2) For maybe-ops encodings, they are better to be