Re: [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str()

John Snow writes: > On 3/23/21 5:40 AM, Markus Armbruster wrote: >> check_name_str() masks leading digits when passed enum_member=True. >> Only check_enum() does. Lift the masking into check_enum(). >> Signed-off-by: Markus Armbruster >> --- >> scripts/qapi/expr.py | 23 ++

Re: [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str()

On 3/23/21 5:40 AM, Markus Armbruster wrote: check_name_str() masks leading digits when passed enum_member=True. Only check_enum() does. Lift the masking into check_enum(). Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 23 ++- 1 file changed, 10 insertions(

Re: [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str()

On 3/23/21 5:40 AM, Markus Armbruster wrote: check_name_str() masks leading digits when passed enum_member=True. Only check_enum() does. Lift the masking into check_enum(). Signed-off-by: Markus Armbruster Sure. Reviewed-by: John Snow --- scripts/qapi/expr.py | 23 ++---

Re: [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str()

On 3/23/21 4:40 AM, Markus Armbruster wrote: > check_name_str() masks leading digits when passed enum_member=True. > Only check_enum() does. Lift the masking into check_enum(). > > Signed-off-by: Markus Armbruster > --- > scripts/qapi/expr.py | 23 ++- > 1 file changed, 10 i

[PATCH 09/28] qapi: Lift enum-specific code out of check_name_str()

check_name_str() masks leading digits when passed enum_member=True. Only check_enum() does. Lift the masking into check_enum(). Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/scripts/qapi/ex