Re: [PATCH 09/26] hw/intc/arm_gicv3_its: Correct handling of MAPI

2021-12-13 Thread Alex Bennée
Peter Maydell writes: > The MAPI command takes arguments DeviceID, EventID, ICID, and is > defined to be equivalent to MAPTI DeviceID, EventID, EventID, ICID. > (That is, where MAPTI takes an explicit pINTID, MAPI uses the EventID > as the pINTID.) > > We didn't quite get this right. In partic

Re: [PATCH 09/26] hw/intc/arm_gicv3_its: Correct handling of MAPI

2021-12-12 Thread Richard Henderson
On 12/11/21 11:11 AM, Peter Maydell wrote: The MAPI command takes arguments DeviceID, EventID, ICID, and is defined to be equivalent to MAPTI DeviceID, EventID, EventID, ICID. (That is, where MAPTI takes an explicit pINTID, MAPI uses the EventID as the pINTID.) We didn't quite get this right. I

[PATCH 09/26] hw/intc/arm_gicv3_its: Correct handling of MAPI

2021-12-11 Thread Peter Maydell
The MAPI command takes arguments DeviceID, EventID, ICID, and is defined to be equivalent to MAPTI DeviceID, EventID, EventID, ICID. (That is, where MAPTI takes an explicit pINTID, MAPI uses the EventID as the pINTID.) We didn't quite get this right. In particular the error checks for MAPI includ