Re: [PATCH 09/25] qapi: Improve reporting of invalid name errors

2019-09-24 Thread Eric Blake
On 9/24/19 8:28 AM, Markus Armbruster wrote: > Split check_name() into check_name_is_str() and check_name_str(), keep > check_name() as a wrapper. > > Move add_name()'s call into its caller check_exprs(), and inline. > > This permits delaying check_name_str() there, so its error message > gains a

[PATCH 09/25] qapi: Improve reporting of invalid name errors

2019-09-24 Thread Markus Armbruster
Split check_name() into check_name_is_str() and check_name_str(), keep check_name() as a wrapper. Move add_name()'s call into its caller check_exprs(), and inline. This permits delaying check_name_str() there, so its error message gains an "in definition" line. Signed-off-by: Markus Armbruster