Re: [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:12 PM Philippe Mathieu-Daudé wrote: > > All the codebase calls memory_region_allocate_system_memory() with > a NULL 'owner' from the board_init() function. > Let pass a MachineState argument, and enforce the QOM ownership of > the system memory. > > Signed-off-by: Philipp

Re: [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument

2019-10-21 Thread Philippe Mathieu-Daudé
On 10/21/19 9:27 AM, Thomas Huth wrote: On 21/10/2019 00.56, Philippe Mathieu-Daudé wrote: All the codebase calls memory_region_allocate_system_memory() with a NULL 'owner' from the board_init() function. It's a little bit weird that you first changed the owner to NULL in patch 7, just to chan

Re: [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument

2019-10-21 Thread Thomas Huth
On 21/10/2019 00.56, Philippe Mathieu-Daudé wrote: > All the codebase calls memory_region_allocate_system_memory() with > a NULL 'owner' from the board_init() function. It's a little bit weird that you first changed the owner to NULL in patch 7, just to change the type of the parameter here and th

[PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument

2019-10-20 Thread Philippe Mathieu-Daudé
All the codebase calls memory_region_allocate_system_memory() with a NULL 'owner' from the board_init() function. Let pass a MachineState argument, and enforce the QOM ownership of the system memory. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/numa.c | 11 +++ include/hw/board