Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-14 Thread Pierrick Bouvier
On 5/14/25 12:13 AM, Markus Armbruster wrote: Pierrick Bouvier writes: On 5/13/25 12:08 AM, Markus Armbruster wrote: Pierrick Bouvier writes: On 5/9/25 11:57 PM, Markus Armbruster wrote: The build system would need generate an input document for the QAPI visitor that defines whether each

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-14 Thread Pierrick Bouvier
On 5/14/25 7:09 AM, Markus Armbruster wrote: Fails to build: /usr/bin/ld: libqemu-x86_64-softmmu.a.p/meson-generated_.._qapi_qapi-commands-machine-target.c.o: in function `qmp_marshal_query_cpu_model_comparison': /work/armbru/qemu/bld-x86/qapi/qapi-commands-machine-target.c:

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-14 Thread Markus Armbruster
Fails to build: /usr/bin/ld: libqemu-x86_64-softmmu.a.p/meson-generated_.._qapi_qapi-commands-machine-target.c.o: in function `qmp_marshal_query_cpu_model_comparison': /work/armbru/qemu/bld-x86/qapi/qapi-commands-machine-target.c:66:(.text+0x10c9): undefined reference to `qmp_q

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-14 Thread Markus Armbruster
Pierrick Bouvier writes: > On 5/13/25 12:08 AM, Markus Armbruster wrote: >> Pierrick Bouvier writes: >> >>> On 5/9/25 11:57 PM, Markus Armbruster wrote: > The build system would need generate an input document for the > QAPI visitor that defines whether each constant is set to true

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-13 Thread Pierrick Bouvier
On 5/13/25 12:08 AM, Markus Armbruster wrote: Pierrick Bouvier writes: On 5/9/25 11:57 PM, Markus Armbruster wrote: The build system would need generate an input document for the QAPI visitor that defines whether each constant is set to true or false, based on suitable CONFIG/TARGET condition

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-13 Thread Markus Armbruster
Pierrick Bouvier writes: > On 5/9/25 11:57 PM, Markus Armbruster wrote: >>> The build system would need generate an input document for the >>> QAPI visitor that defines whether each constant is set to true >>> or false, based on suitable CONFIG/TARGET conditions from meson. >> >> I think the con

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-12 Thread Pierrick Bouvier
On 5/9/25 11:57 PM, Markus Armbruster wrote: The build system would need generate an input document for the QAPI visitor that defines whether each constant is set to true or false, based on suitable CONFIG/TARGET conditions from meson. I think the conditions that are evaluated at build time in

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, May 07, 2025 at 04:14:39PM -0700, Pierrick Bouvier wrote: >> Signed-off-by: Pierrick Bouvier >> --- >> qapi/machine-target.json | 84 >> qapi/misc-target.json| 48 --- >> scripts/qapi/expr.py

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-08 Thread Pierrick Bouvier
On 5/8/25 7:40 AM, Daniel P. Berrangé wrote: On Wed, May 07, 2025 at 04:14:39PM -0700, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- qapi/machine-target.json | 84 qapi/misc-target.json| 48 --- scripts/qapi/expr

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-08 Thread Daniel P . Berrangé
On Wed, May 07, 2025 at 04:14:39PM -0700, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- > qapi/machine-target.json | 84 > qapi/misc-target.json| 48 --- > scripts/qapi/expr.py | 9 +++-- > 3 files changed, 81

Re: [PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-07 Thread Philippe Mathieu-Daudé
On 8/5/25 01:14, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- qapi/machine-target.json | 84 qapi/misc-target.json| 48 --- scripts/qapi/expr.py | 9 +++-- 3 files changed, 81 insertions(+), 60 deletions(-)

[PATCH 09/13] qapi: transform target specific 'if' in runtime checks

2025-05-07 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- qapi/machine-target.json | 84 qapi/misc-target.json| 48 --- scripts/qapi/expr.py | 9 +++-- 3 files changed, 81 insertions(+), 60 deletions(-) diff --git a/qapi/machine-target.json b/qapi/