Re: [PATCH 09/12] replay: Simplify setting replay blockers

2023-02-07 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/2/23 08:51, Markus Armbruster wrote: >> replay_add_blocker() takes an Error *. All callers pass one created >> like this: >> >> error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED, "some feature"); >> >> Folding this into replay_add_blocker() simplifies th

Re: [PATCH 09/12] replay: Simplify setting replay blockers

2023-02-07 Thread Philippe Mathieu-Daudé
On 7/2/23 08:51, Markus Armbruster wrote: replay_add_blocker() takes an Error *. All callers pass one created like this: error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED, "some feature"); Folding this into replay_add_blocker() simplifies the callers, losing a bit of generality we haven't ne

[PATCH 09/12] replay: Simplify setting replay blockers

2023-02-06 Thread Markus Armbruster
replay_add_blocker() takes an Error *. All callers pass one created like this: error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED, "some feature"); Folding this into replay_add_blocker() simplifies the callers, losing a bit of generality we haven't needed in more than six years. Since there are