Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled

2023-05-25 Thread Philippe Mathieu-Daudé
On 25/5/23 14:55, Peter Maydell wrote: On Thu, 25 May 2023 at 13:52, Alex Bennée wrote: Peter Maydell writes: On Mon, 22 May 2023 at 16:32, Philippe Mathieu-Daudé wrote: Do not transmit characters when UART or transmitter are disabled. Signed-off-by: Philippe Mathieu-Daudé Last time

Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled

2023-05-25 Thread Peter Maydell
On Thu, 25 May 2023 at 13:52, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Mon, 22 May 2023 at 16:32, Philippe Mathieu-Daudé > > wrote: > >> > >> Do not transmit characters when UART or transmitter are disabled. > >> > >> Signed-off-by: Philippe Mathieu-Daudé > > > > Last time someb

Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled

2023-05-25 Thread Alex Bennée
Peter Maydell writes: > On Mon, 22 May 2023 at 16:32, Philippe Mathieu-Daudé > wrote: >> >> Do not transmit characters when UART or transmitter are disabled. >> >> Signed-off-by: Philippe Mathieu-Daudé > > Last time somebody tried to add checks on the tx/rx enable bits > for the PL011 it bro

Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled

2023-05-25 Thread Peter Maydell
On Mon, 22 May 2023 at 16:32, Philippe Mathieu-Daudé wrote: > > Do not transmit characters when UART or transmitter are disabled. > > Signed-off-by: Philippe Mathieu-Daudé Last time somebody tried to add checks on the tx/rx enable bits for the PL011 it broke 'make check' because the hand-rolled

Re: [PATCH 09/12] hw/char/pl011: Check if transmitter is enabled

2023-05-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Do not transmit characters when UART or transmitter are disabled. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 09/12] hw/char/pl011: Check if transmitter is enabled

2023-05-22 Thread Philippe Mathieu-Daudé
Do not transmit characters when UART or transmitter are disabled. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/pl011.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index c55ef41fbf..30bedeac15 100644 --- a/hw/char/pl011.c +++ b