Re: [PATCH 09/11] target/i386: fix TF/RF handling for HLT

2024-06-04 Thread Richard Henderson
On 6/4/24 02:18, Paolo Bonzini wrote: HLT uses DISAS_NORETURN because the corresponding helper calls cpu_loop_exit(). However, while gen_eob() clears HF_RF_MASK and synthesizes a #DB exception if single-step is active, none of this is done by HLT. Note that the single-step trap is generated aft

[PATCH 09/11] target/i386: fix TF/RF handling for HLT

2024-06-04 Thread Paolo Bonzini
HLT uses DISAS_NORETURN because the corresponding helper calls cpu_loop_exit(). However, while gen_eob() clears HF_RF_MASK and synthesizes a #DB exception if single-step is active, none of this is done by HLT. Note that the single-step trap is generated after the halt is finished. Signed-off-by: