Re: [PATCH 09/10] spice: Put spice functions in a separate load module

2020-06-30 Thread Christophe de Dinechin
On 2020-06-30 at 01:00 CEST, Gerd Hoffmann wrote... > Hi, > >> > If so the more normal approach would be to have a struct defining >> > a set of callbacks, that can be registered. Or if there's a natural >> > fit with QOM, then a QOM interface that can then have a QOM object >> > impl registere

Re: [PATCH 09/10] spice: Put spice functions in a separate load module

2020-06-29 Thread Gerd Hoffmann
Hi, > > If so the more normal approach would be to have a struct defining > > a set of callbacks, that can be registered. Or if there's a natural > > fit with QOM, then a QOM interface that can then have a QOM object > > impl registered as a singleton. > > That was my second attempt (after the

Re: [PATCH 09/10] spice: Put spice functions in a separate load module

2020-06-29 Thread Daniel P . Berrangé
On Mon, Jun 29, 2020 at 07:19:41PM +0200, Christophe de Dinechin wrote: > > On 2020-06-26 at 19:35 CEST, Daniel P. Berrangé wrote... > > On Fri, Jun 26, 2020 at 06:43:06PM +0200, Christophe de Dinechin wrote: > >> Use the MODIFACE and MODIMPL macros to to redirect the highest-level > >> qemu_spice

Re: [PATCH 09/10] spice: Put spice functions in a separate load module

2020-06-29 Thread Christophe de Dinechin
On 2020-06-26 at 19:35 CEST, Daniel P. Berrangé wrote... > On Fri, Jun 26, 2020 at 06:43:06PM +0200, Christophe de Dinechin wrote: >> Use the MODIFACE and MODIMPL macros to to redirect the highest-level >> qemu_spice functions into the spice-app.so load module when SPICE is >> compiled as a modul

Re: [PATCH 09/10] spice: Put spice functions in a separate load module

2020-06-26 Thread Daniel P . Berrangé
On Fri, Jun 26, 2020 at 06:43:06PM +0200, Christophe de Dinechin wrote: > Use the MODIFACE and MODIMPL macros to to redirect the highest-level > qemu_spice functions into the spice-app.so load module when SPICE is > compiled as a module. > > With these changes, the following shared libraries are n

[PATCH 09/10] spice: Put spice functions in a separate load module

2020-06-26 Thread Christophe de Dinechin
Use the MODIFACE and MODIMPL macros to to redirect the highest-level qemu_spice functions into the spice-app.so load module when SPICE is compiled as a module. With these changes, the following shared libraries are no longer necessary in the top-level qemu binary: libspice-server.so.1 =>