Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED

2023-02-07 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Tue, Feb 7, 2023 at 10:53 AM Juan Quintela wrote: > Markus Armbruster wrote: > > slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED. > > This macro never existed. The reference got added in commit > > e3d4d25206a "guest agent: add guest agent

Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED. > This macro never existed. The reference got added in commit > e3d4d25206a "guest agent: add guest agent RPCs/commands" along with > QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However, > QE

[PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED

2023-02-06 Thread Markus Armbruster
slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED. This macro never existed. The reference got added in commit e3d4d25206a "guest agent: add guest agent RPCs/commands" along with QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However, QERR_QGA_LOGGING_FAILED was never actu