Re: [PATCH 08/12] qdev: Make qdev_get_machine() not use container_get()

2024-11-21 Thread Peter Xu
On Thu, Nov 21, 2024 at 10:21:48AM +, Daniel P. Berrangé wrote: > On Wed, Nov 20, 2024 at 04:56:59PM -0500, Peter Xu wrote: > > Currently, qdev_get_machine() has a slight misuse on container_get(), as > > the helper says "get a container" but in reality the goal is to get the > > machine object

Re: [PATCH 08/12] qdev: Make qdev_get_machine() not use container_get()

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:56:59PM -0500, Peter Xu wrote: > Currently, qdev_get_machine() has a slight misuse on container_get(), as > the helper says "get a container" but in reality the goal is to get the > machine object. It is still a "container" but not strictly. > > Note that it _may_ get a

[PATCH 08/12] qdev: Make qdev_get_machine() not use container_get()

2024-11-20 Thread Peter Xu
Currently, qdev_get_machine() has a slight misuse on container_get(), as the helper says "get a container" but in reality the goal is to get the machine object. It is still a "container" but not strictly. Note that it _may_ get a container (at "/machine") in our current unit test of test-qdev-glo