Re: [PATCH 07/18] iotests: Replace IMGOPTS= by -o

2019-09-30 Thread Maxim Levitsky
On Mon, 2019-09-30 at 15:00 +0200, Max Reitz wrote: > On 29.09.19 18:33, Maxim Levitsky wrote: > > On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote: > > > Tests should not overwrite all user-supplied image options, but only add > > > to it (which will effectively overwrite conflicting values). A

Re: [PATCH 07/18] iotests: Replace IMGOPTS= by -o

2019-09-30 Thread Max Reitz
On 29.09.19 18:33, Maxim Levitsky wrote: > On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote: >> Tests should not overwrite all user-supplied image options, but only add >> to it (which will effectively overwrite conflicting values). Accomplish >> this by passing options to _make_test_img via -o

Re: [PATCH 07/18] iotests: Replace IMGOPTS= by -o

2019-09-29 Thread Maxim Levitsky
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote: > Tests should not overwrite all user-supplied image options, but only add > to it (which will effectively overwrite conflicting values). Accomplish > this by passing options to _make_test_img via -o instead of $IMGOPTS. > > For some tests, ther

[PATCH 07/18] iotests: Replace IMGOPTS= by -o

2019-09-27 Thread Max Reitz
Tests should not overwrite all user-supplied image options, but only add to it (which will effectively overwrite conflicting values). Accomplish this by passing options to _make_test_img via -o instead of $IMGOPTS. For some tests, there is no functional change because they already only appended o