Re: [PATCH 07/17] hw/misc/max111x: Don't use vmstate_register()

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:25 AM Peter Maydell wrote: > > The max111x is a proper qdev device; we can use dc->vmsd rather than > directly calling vmstate_register(). > > It's possible that this is a migration compat break, but the only > boards that use this device are the spitz-family ('akita', 'b

Re: [PATCH 07/17] hw/misc/max111x: Don't use vmstate_register()

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > The max111x is a proper qdev device; we can use dc->vmsd rather than > directly calling vmstate_register(). > > It's possible that this is a migration compat break, but the only > boards that use this device are the spitz-family ('akita', 'borzoi', > 'spi

[PATCH 07/17] hw/misc/max111x: Don't use vmstate_register()

2020-06-28 Thread Peter Maydell
The max111x is a proper qdev device; we can use dc->vmsd rather than directly calling vmstate_register(). It's possible that this is a migration compat break, but the only boards that use this device are the spitz-family ('akita', 'borzoi', 'spitz', 'terrier'). Signed-off-by: Peter Maydell ---