Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Liran Alon
On 10/03/2020 16:39, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 04:24:45PM +0200, Liran Alon wrote: Re-thinking about this... QEMU VMPort interface was quite broken already (See first patch in series "hw/i386/vmport: Propagate IOPort read to vCPU EAX register"). The introduction of th

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 04:24:45PM +0200, Liran Alon wrote: > > On 10/03/2020 13:22, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:13:21PM +0200, Liran Alon wrote: > > > On 10/03/2020 11:34, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: >

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Liran Alon
On 10/03/2020 13:22, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:13:21PM +0200, Liran Alon wrote: On 10/03/2020 11:34, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: This is VMware documented functionallity that some guests rely on. Returns the

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 02:37:07PM +0200, Liran Alon wrote: > So I think you are right this should be le32_to_cpu(). i.e. Treat the > uuid_part[x] as little-endian and convert it to native CPU format. > > I always get confused in this :) > > Thanks, > -Liran Yes - Linux has tagging for this so o

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Liran Alon
On 10/03/2020 14:01, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 04:44:54AM -0700, Liran Alon wrote: On 10/03/2020 11:22, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: This is VMware documented functionallity that some guests rely on. Returns the

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 04:44:54AM -0700, Liran Alon wrote: > > On 10/03/2020 11:22, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: > > > This is VMware documented functionallity that some guests rely on. > > > Returns the BIOS UUID of the current virtual

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Liran Alon
On 10/03/2020 11:22, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: This is VMware documented functionallity that some guests rely on. Returns the BIOS UUID of the current virtual machine. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Liran Alon
On 10/03/2020 13:22, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:13:21PM +0200, Liran Alon wrote: On 10/03/2020 11:34, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: This is VMware documented functionallity that some guests rely on. Returns the

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:13:21PM +0200, Liran Alon wrote: > > On 10/03/2020 11:34, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: > > > This is VMware documented functionallity that some guests rely on. > > > Returns the BIOS UUID of the current virtual

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Liran Alon
On 10/03/2020 11:34, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: This is VMware documented functionallity that some guests rely on. Returns the BIOS UUID of the current virtual machine. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon So this

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: > This is VMware documented functionallity that some guests rely on. > Returns the BIOS UUID of the current virtual machine. > > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon So this at least seems guest-visible. So I suspe

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: > This is VMware documented functionallity that some guests rely on. > Returns the BIOS UUID of the current virtual machine. > > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- > hw/i386/vmport.c | 14 ++

[PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-09 Thread Liran Alon
This is VMware documented functionallity that some guests rely on. Returns the BIOS UUID of the current virtual machine. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 14 ++ include/hw/i386/pc.h | 1 + 2 files changed, 15 insertions(+) diff --gi