Re: [PATCH 07/11] mips/malta: Fix create_cps() error handling

2020-04-29 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > +Peter for crediting his advice. > > On 4/29/20 7:59 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 4/24/20 9:20 PM, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a var

Re: [PATCH 07/11] mips/malta: Fix create_cps() error handling

2020-04-29 Thread Philippe Mathieu-Daudé
+Peter for crediting his advice. On 4/29/20 7:59 AM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 4/24/20 9:20 PM, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the la

Re: [PATCH 07/11] mips/malta: Fix create_cps() error handling

2020-04-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/24/20 9:20 PM, Markus Armbruster wrote: >> The Error ** argument must be NULL, &error_abort, &error_fatal, or a >> pointer to a variable containing NULL. Passing an argument of the >> latter kind twice without clearing it in between is wrong: if the >> first

Re: [PATCH 07/11] mips/malta: Fix create_cps() error handling

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/24/20 9:20 PM, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer point

[PATCH 07/11] mips/malta: Fix create_cps() error handling

2020-04-24 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second create_cps() is wrong that