Re: [PATCH 06/22] exec/cpu: Call cpu_remove_sync() once in cpu_common_unrealize()

2025-01-22 Thread Igor Mammedov
On Thu, 16 Jan 2025 19:05:46 +0100 Philippe Mathieu-Daudé wrote: > On 28/11/23 17:42, Igor Mammedov wrote: > > On Mon, 18 Sep 2023 18:02:39 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> While create_vcpu_thread() creates a vCPU thread, its counterpart > >> is cpu_remove_sync(), which join

Re: [PATCH 06/22] exec/cpu: Call cpu_remove_sync() once in cpu_common_unrealize()

2025-01-16 Thread Philippe Mathieu-Daudé
On 16/1/25 19:05, Philippe Mathieu-Daudé wrote: On 28/11/23 17:42, Igor Mammedov wrote: On Mon, 18 Sep 2023 18:02:39 +0200 Philippe Mathieu-Daudé wrote: While create_vcpu_thread() creates a vCPU thread, its counterpart is cpu_remove_sync(), which join and destroy the thread. create_vcpu_thre

Re: [PATCH 06/22] exec/cpu: Call cpu_remove_sync() once in cpu_common_unrealize()

2025-01-16 Thread Philippe Mathieu-Daudé
On 28/11/23 17:42, Igor Mammedov wrote: On Mon, 18 Sep 2023 18:02:39 +0200 Philippe Mathieu-Daudé wrote: While create_vcpu_thread() creates a vCPU thread, its counterpart is cpu_remove_sync(), which join and destroy the thread. create_vcpu_thread() is called in qemu_init_vcpu(), itself called

Re: [PATCH 06/22] exec/cpu: Call cpu_remove_sync() once in cpu_common_unrealize()

2023-11-28 Thread Igor Mammedov
On Mon, 18 Sep 2023 18:02:39 +0200 Philippe Mathieu-Daudé wrote: > While create_vcpu_thread() creates a vCPU thread, its counterpart > is cpu_remove_sync(), which join and destroy the thread. > > create_vcpu_thread() is called in qemu_init_vcpu(), itself called > in cpu_common_realizefn(). Since

Re: [PATCH 06/22] exec/cpu: Call cpu_remove_sync() once in cpu_common_unrealize()

2023-09-29 Thread Richard Henderson
On 9/18/23 09:02, Philippe Mathieu-Daudé wrote: While create_vcpu_thread() creates a vCPU thread, its counterpart is cpu_remove_sync(), which join and destroy the thread. create_vcpu_thread() is called in qemu_init_vcpu(), itself called in cpu_common_realizefn(). Since we don't have qemu_deinit_

[PATCH 06/22] exec/cpu: Call cpu_remove_sync() once in cpu_common_unrealize()

2023-09-18 Thread Philippe Mathieu-Daudé
While create_vcpu_thread() creates a vCPU thread, its counterpart is cpu_remove_sync(), which join and destroy the thread. create_vcpu_thread() is called in qemu_init_vcpu(), itself called in cpu_common_realizefn(). Since we don't have qemu_deinit_vcpu() helper (we probably don't need any), simply